8267935: Replace BasicHashtable and Hashtable

[afshin-zafari]

Description

Hashtable class to be replaced with ResourceHashtable class in all source code.

Patch

The only instance was #include \"hashtable.hpp\" in jvmtiTagMapTable.cpp and removed.
The corresponding files (hashtable.hpp, hashtable.inline.hpp and hashtable.cpp) are removed too.

Test

mach5 tier1 all platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8267935: Replace BasicHashtable and Hashtable

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Robbin Ehn (@robehn - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12275/head:pull/12275
$ git checkout pull/12275

Update a local copy of the PR:
$ git checkout pull/12275
$ git pull https://git.openjdk.org/jdk pull/12275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12275

View PR using the GUI difftool:
$ git pr show -t 12275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12275.diff

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dc4f236c)

[coleenp]

Great! thank you!

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267935: Replace BasicHashtable and Hashtable

Reviewed-by: coleenp, rehn, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• a74ebd0: 8299325: java/net/httpclient/CancelRequestTest.java fails "test CancelRequestTest.testGetSendAsync("https://localhost:46509/https1/x/same/interrupt", true, true)"
• 041a12e: 8301255: Http2Connection may send too many GOAWAY frames
• 476f58a: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4
• ebb84ad: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
• 61a5f11: 8301033: RISC-V: Handle special cases for MinI/MaxI nodes for Zbb
• 82df4a2: 8301148: Serial: Remove ContiguousSpace::reset_saved_mark
• c672ed1: 8301248: Less side effects in InstanceRefKlass::trace_reference_gc
• cee4bd3: 8301047: Clean up type unsafe uses of oop from compiler code
• 7fae3a1: 8301229: Clean up SuspendibleThreadSet::_suspend_all
• f50cda7: 8301217: Remove FilteringClosure
• ... and 33 more: https://git.openjdk.org/jdk/compare/f7da09c34918eea434c82af22b1da1f2a5b35f35...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @robehn, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[robehn]

Thank you!

[afshin-zafari]

/integrate

[openjdk]

@afshin-zafari
Your change (at version dc4f236) is now ready to be sponsored by a Committer.

[tschatzl]

/sponsor

[openjdk]

Going to push as commit f4592b1.
Since your change was applied there have been 43 commits pushed to the master branch:

• a74ebd0: 8299325: java/net/httpclient/CancelRequestTest.java fails "test CancelRequestTest.testGetSendAsync("https://localhost:46509/https1/x/same/interrupt", true, true)"
• 041a12e: 8301255: Http2Connection may send too many GOAWAY frames
• 476f58a: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4
• ebb84ad: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
• 61a5f11: 8301033: RISC-V: Handle special cases for MinI/MaxI nodes for Zbb
• 82df4a2: 8301148: Serial: Remove ContiguousSpace::reset_saved_mark
• c672ed1: 8301248: Less side effects in InstanceRefKlass::trace_reference_gc
• cee4bd3: 8301047: Clean up type unsafe uses of oop from compiler code
• 7fae3a1: 8301229: Clean up SuspendibleThreadSet::_suspend_all
• f50cda7: 8301217: Remove FilteringClosure
• ... and 33 more: https://git.openjdk.org/jdk/compare/f7da09c34918eea434c82af22b1da1f2a5b35f35...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl @afshin-zafari Pushed as commit f4592b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.