8301459: Serial: Merge KeepAliveClosure into FastKeepAliveClosure

[albertnetymk]

Simple removing unnecessary type hierarchy.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301459: Serial: Merge KeepAliveClosure into FastKeepAliveClosure

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12310/head:pull/12310
$ git checkout pull/12310

Update a local copy of the PR:
$ git checkout pull/12310
$ git pull https://git.openjdk.org/jdk pull/12310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12310

View PR using the GUI difftool:
$ git pr show -t 12310

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12310.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (10c7c82f)

[stefank]

Looks good.

There seems to be an opportunity to further clean this up by renaming FastKeepAliveClosure to KeepAliveClosure. I also think that the definition of this closure could be moved to defNewGeneration.cpp

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301459: Serial: Merge KeepAliveClosure into FastKeepAliveClosure

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 33e653e: 8301448: [BACKOUT] CodeHeap has virtual methods that are not overridden
• cdb4ba9: 8301326: Optimize compiler/uncommontrap/TestDeoptOOM.java test
• 9cc0171: 8301153: RISC-V: pipeline class for several instructions is not set correctly
• 633e291: 8301067: RISC-V: better error message when reporting unsupported satp modes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

There seems to be an opportunity to further clean this up by renaming FastKeepAliveClosure to KeepAliveClosure. I also think that the definition of this closure could be moved to defNewGeneration.cpp

Yes; will do so in a follow-up PR.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit a0aed9b.
Since your change was applied there have been 18 commits pushed to the master branch:

• d269ebb: 8301570: Test runtime/jni/nativeStack/ needs to detach the native thread
• 8164cfb: 8300696: [AIX] AttachReturnError fails
• 09bfbf8: 8300909: Update com/sun/jndi/dns/Test6991580.java manual test instruction
• 6beadbb: 8293519: deprecation warnings should be emitted for uses of annotation methods inside other annotations
• 4bef233: 8301549: Fix comment about ClassCircularityError
• e1bf471: 8301555: Remove constantPoolCacheKlass friend
• 5744c91: 8297158: Suspicious collection method call in Types.isSameTypeVisitor
• e193a0b: 8295951: intermittent cmp_baseline task failures with CDS files
• 60c535d: 8301340: Make DirtyCardToOopClosure stack-allocated
• b76a52f: 8301076: Replace NULL with nullptr in share/prims/
• ... and 8 more: https://git.openjdk.org/jdk/compare/4b0e259d1651c2131031e581fdc0482858325081...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit a0aed9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.