Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel #12311

Closed
wants to merge 2 commits into from
Closed

8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel #12311

wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 31, 2023 •
edited by openjdk bot

Simple removing unnecessary code and adding API documentation.

Test: hotspot_gc

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12311/head:pull/12311
$ git checkout pull/12311

Update a local copy of the PR:
$ git checkout pull/12311
$ git pull https://git.openjdk.org/jdk pull/12311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12311

View PR using the GUI difftool:
$ git pr show -t 12311

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12311.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8301465 8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel Jan 31, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2023
@openjdk
Copy link

openjdk bot commented Jan 31, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2023 •
edited

Webrevs

tschatzl
tschatzl suggested changes Jan 31, 2023
View reviewed changes
src/hotspot/share/code/codeCache.cpp Outdated
Comment on lines 875 to 880
// Arm nmethods so that special actions are taken (nmethod_entry_barrier) for
// on-stack nmethods. It's used in two places:
// 1. Used before the start of concurrent marking so that oops inside on-stack
// nmethods are visited.
// 2. Used at the end of (stw/concurrent) marking so that nmethod::_gc_epoch is
// up-to-date, which provides more accurate estimate of nmethod::is_cold.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have general documentation and usage information about a method in the .hpp file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved.

tschatzl
tschatzl approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 1, 2023 •
edited

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

  • 8f195ff: 8298952: All nodes should have type(n) == Value(n) after IGVN
  • e88fd8c: 8301768: G1: Remove unimplemented HeapRegionRemSet::split_card
  • 96c50a3: 8301752: [IR Framework] Add more IR framework examples
  • 3646c4e: 8301171: Rename sanitizers/address.h to sanitizers/address.hpp
  • 3f3356b: 8301760: Fix possible leak in SpNegoContext dispose
  • b4cb6c8: 8301743: RISC-V: Add InlineSkippedInstructionsCounter to post-call nops
  • 4dd6e8f: 8301740: RISC-V: Address::uses() should check address mode
  • 8507db1: 8301628: RISC-V: c2 fix pipeline class for several instructions
  • d67bfe2: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
  • 3449324: 8301396: Port fdlibm expm1 to Java
  • ... and 81 more: https://git.openjdk.org/jdk/compare/4b0e259d1651c2131031e581fdc0482858325081...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

Going to push as commit 371a0c4.
Since your change was applied there have been 93 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2023
@openjdk openjdk bot closed this Feb 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@albertnetymk Pushed as commit 371a0c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the arm-nmethod branch February 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschatzl tschatzl tschatzl approved these changes

@walulyai walulyai walulyai approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
3 participants
@albertnetymk @tschatzl @walulyai