New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8300098 : java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3 #12319
Conversation
…ateTest.java fails with internal timeout when executed with TieredCompilation1/3
/contributor add @DougLea |
👋 Welcome back viktorklang-ora! A progress list of the required criteria for merging this PR into |
@viktorklang-ora |
@viktorklang-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Viktor, I don't have enough knowledge of this area, but looking at this change and going by what Doug noted in the JBS issue:
There's a CHM bug scenario that I haven't been able to rule out after looking at this again: A late clearing of waiter field in ConcurrentHashMap.contendedLock by a previous waiter. There may be a constraint I've forgotten that makes this impossible in principle, but it is easy to change to be more clearly correct by replacing the writes with CASes
this change looks OK to me.
You might have to add a noreg-hard
label to that JBS issue.
@viktorklang-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 115 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @AlanBateman) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@viktorklang-ora |
/sponsor |
Going to push as commit ecf8842.
Your commit was automatically rebased without conflicts. |
@AlanBateman @viktorklang-ora Pushed as commit ecf8842. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The proposed fix by @DougLea ensures that the state transition into waiting is retried in the cases where a previous waiter isn't making progress and a new waiter goes into waiting.
Progress
Issue
Reviewers
Contributors
<dl@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12319/head:pull/12319
$ git checkout pull/12319
Update a local copy of the PR:
$ git checkout pull/12319
$ git pull https://git.openjdk.org/jdk pull/12319/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12319
View PR using the GUI difftool:
$ git pr show -t 12319
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12319.diff