JDK-8301513: Replace NULL with nullptr in os_cpu/windows_x86

[jdksjolen]

Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory os_cpu/windows_x86. Unfortunately the script that does the change isn't perfect, and so we
need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.

Here are some typical things to look out for:

1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.

An example of this:

// This function returns null
void* ret_null();
// This function returns true if *x == nullptr
bool is_nullptr(void** x);

Note how nullptr participates in a code expression here, we really are talking about the specific value nullptr.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301513: Replace NULL with nullptr in os_cpu/windows_x86

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12341/head:pull/12341
$ git checkout pull/12341

Update a local copy of the PR:
$ git checkout pull/12341
$ git pull https://git.openjdk.org/jdk pull/12341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12341

View PR using the GUI difftool:
$ git pr show -t 12341

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12341.diff

[jdksjolen]

Looks OK and trivial to me.

[bridgekeeper]

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jdksjolen The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c9aca7a1)

[kimbarrett]

Looks good, and trivial.

[openjdk]

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301513: Replace NULL with nullptr in os_cpu/windows_x86

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• b76a52f: 8301076: Replace NULL with nullptr in share/prims/
• 90ec19e: 8301068: Replace NULL with nullptr in share/jvmci/
• 419409b: 8301337: Remove unused os::_polling_page
• d583767: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• 810c8a2: 8301170: perfMemory_windows.cpp add free_security_attr to early returns
• 33e653e: 8301448: [BACKOUT] CodeHeap has virtual methods that are not overridden
• cdb4ba9: 8301326: Optimize compiler/uncommontrap/TestDeoptOOM.java test
• 9cc0171: 8301153: RISC-V: pipeline class for several instructions is not set correctly
• 633e291: 8301067: RISC-V: better error message when reporting unsupported satp modes
• 4b0e259: 8301344: G1: Remove DirtyCardToOopClosure forward declaration in g1OopClosures.hpp
• ... and 54 more: https://git.openjdk.org/jdk/compare/107e184d59c0bbed6441a3c1a9bfd4527da3bce5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jdksjolen]

Thanks!

/integrate

[openjdk]

Going to push as commit c109dae.
Since your change was applied there have been 97 commits pushed to the master branch:

• 182d1b2: 8301507: Replace NULL with nullptr in os_cpu/linux_riscv
• 5d1f71d: 8301509: Replace NULL with nullptr in os_cpu/linux_x86
• 6daff6b: 8301502: Replace NULL with nullptr in os_cpu/bsd_x86
• 13fcd60: 8301504: Replace NULL with nullptr in os_cpu/linux_aarch64
• b1e9698: 8301506: Replace NULL with nullptr in os_cpu/linux_ppc
• af474ce: 8297582: C2: very slow compilation due to type system verification code
• 8d6e8a4: 8301618: Compare elements and type mirrors properly
• d683212: Merge
• 1330d4e: 8298377: JfrVframeStream causes deadlocks in ZGC
• 225f805: 8299891: JMX ObjectInputFilter additional classes needed
• ... and 87 more: https://git.openjdk.org/jdk/compare/107e184d59c0bbed6441a3c1a9bfd4527da3bce5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jdksjolen Pushed as commit c109dae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.