JDK-8301636: Minor cleanup in CommentHelper and DocPretty

[jonathan-gibbons]

Please review some simple cleanup suggested by IntelliJ IDEA that would be too much of a distraction in an otherwise unrelated PR.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301636: Minor cleanup in CommentHelper and DocPretty

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12375/head:pull/12375
$ git checkout pull/12375

Update a local copy of the PR:
$ git checkout pull/12375
$ git pull https://git.openjdk.org/jdk pull/12375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12375

View PR using the GUI difftool:
$ git pr show -t 12375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12375.diff

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jonathan-gibbons]

For what it's worth, I dislike the remaining getReferencedThing methods remaining in this class, since they are just null-safe wrappers around methods in Utils that are just wrappers for code in java.lang.model. But that's another more-manual cleanup for another day.

[openjdk]

@jonathan-gibbons The following labels will be automatically applied to this pull request:

• compiler
• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (85c5695b)

[pavelrappo]

Looks good (assuming tests pass).

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301636: Minor cleanup in CommentHelper and DocPretty

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 960c393: 8301393: Include cdb in the Windows devkit
• 6c927c9: 8301299: Wrong class spec on sun.security.util.Pem
• 51ac878: 8284236: Remove java/lang/ref/ReferenceEnqueue.java from ProblemList-Xcomp.txt

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit 930ec00.
Since your change was applied there have been 28 commits pushed to the master branch:

• 725d57b: 8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc
• 2d50c7d: 8298979: Remove duplicated serviceability/jvmti/thread/GetAllThreads/allthr01/allthr01.java
• 59b7fb1: 8300273: [IR framework] Handle message instead of bailing out
• 5b1584b: 8298880: VectorLogicalOpIdentityTest.java IR test incorrectly use avx3 instead of avx512
• 21c1afb: 8301612: OopLoadProxy constructor should be explicit
• 03b23a1: 8301367: Add exception handler method to the BaseLdapServer
• 7b6ac41: 8286876: NMT.test_unaliged_block_address_vm_assert fails if using clang toolchain
• d097b5e: 8301508: Replace NULL with nullptr in os_cpu/linux_s390
• c8307e3: 8301500: Replace NULL with nullptr in os_cpu/aix_ppc
• 218223e: 8301501: Replace NULL with nullptr in os_cpu/bsd_aarch64
• ... and 18 more: https://git.openjdk.org/jdk/compare/995210873497eb2400b7672096e6f3cac7fde9a6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit 930ec00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.