New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301788: AlgorithmId should keep lowercase characters from 3rd party providers #12410
Conversation
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
Webrevs
|
* @library /test/lib | ||
* @summary AlgorithmId should keep lowercase characters from 3rd party providers | ||
* @modules java.base/sun.security.x509 | ||
* java.base/sun.security.util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AlgorithmId.get(ALG).getOID().toString()
calls sun.security.util.ObjectIdentifier::toString
.
Uppercase.java:46: error: ObjectIdentifier.toString() in package sun.security.util is not accessible
Asserts.assertEQ(AlgorithmId.get(ALG).getOID().toString(), OID);
^
(package sun.security.util is declared in module java.base, which does not export it to the unnamed module)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@wangweij This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b569742.
Your commit was automatically rebased without conflicts. |
Keep the "NAME -> 1.2.3.4" mapping unchanged but modify "1.2.3.4 -> NAME" to "1.2.3.4 -> Name".
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12410/head:pull/12410
$ git checkout pull/12410
Update a local copy of the PR:
$ git checkout pull/12410
$ git pull https://git.openjdk.org/jdk pull/12410/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12410
View PR using the GUI difftool:
$ git pr show -t 12410
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12410.diff