JDK-8301842: JFR: increase checkpoint event size for stacktrace and string pool

[kvergizova]

Could I have a review of a follow up fix to JDK-8298129.
JDK-8298129 increases checkpoint event size beyond u4 limit, but doesn't support it for stacktrace and string pools, that can exceed this limit.
Tested with jdk/jfr and tier1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301842: JFR: increase checkpoint event size for stacktrace and string pool

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12432/head:pull/12432
$ git checkout pull/12432

Update a local copy of the PR:
$ git checkout pull/12432
$ git pull https://git.openjdk.org/jdk pull/12432/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12432

View PR using the GUI difftool:
$ git pr show -t 12432

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12432.diff

[bridgekeeper]

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kvergizova The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7e079bbd)

[kvergizova]

Pre-submit tests failures are unrelated.

[mgronlun]

Hi Ekaterina, thank you for complementing my incomplete fix for JDK-8298129. I completely missed that stacktrace and string pool serialization are done as part of jfrRecorderService.cpp.

The changes look good, thanks for fixing!

[openjdk]

@kvergizova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301842: JFR: increase checkpoint event size for stacktrace and string pool

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 153 new commits pushed to the master branch:

• 7c50ab1: 8225409: G1: Remove the Hot Card Cache
• 92474f1: 8301243: java/net/httpclient/http2/IdleConnectionTimeoutTest.java intermittent failure
• ee5f6e1: 8302337: JDK crashes if lib/modules contains non-zero byte containing ATTRIBUTE_END
• 7f71a10: 8301874: BarrierSetC2 should assign barrier data to stores
• d782125: 8302214: Typo in javadoc of Arrays.compare and Arrays.mismatch
• 94e7cc8: 8301226: Add clamp() methods to java.lang.Math and to StrictMath
• 13b1ebb: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions
• abbeb7e: 8302108: Clean up placeholder supername code
• d503c66: 8302155: [AIX] NUM_LCPU is not required variable
• c37e9d1: 8298293: NMT: os::realloc() should verify that flags do not change between reallocations
• ... and 143 more: https://git.openjdk.org/jdk/compare/c647ae6c326ca9b712e01d2062196aaed3c6036b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mgronlun) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kvergizova]

/integrate

[openjdk]

@kvergizova
Your change (at version 7e079bb) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 7dfe75c.
Since your change was applied there have been 154 commits pushed to the master branch:

• 66742c8: 8302368: [ZGC] Client build fails after JDK-8300255
• 7c50ab1: 8225409: G1: Remove the Hot Card Cache
• 92474f1: 8301243: java/net/httpclient/http2/IdleConnectionTimeoutTest.java intermittent failure
• ee5f6e1: 8302337: JDK crashes if lib/modules contains non-zero byte containing ATTRIBUTE_END
• 7f71a10: 8301874: BarrierSetC2 should assign barrier data to stores
• d782125: 8302214: Typo in javadoc of Arrays.compare and Arrays.mismatch
• 94e7cc8: 8301226: Add clamp() methods to java.lang.Math and to StrictMath
• 13b1ebb: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions
• abbeb7e: 8302108: Clean up placeholder supername code
• d503c66: 8302155: [AIX] NUM_LCPU is not required variable
• ... and 144 more: https://git.openjdk.org/jdk/compare/c647ae6c326ca9b712e01d2062196aaed3c6036b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @kvergizova Pushed as commit 7dfe75c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.