8302268: Prefer ArrayList to LinkedList in XEmbeddedFramePeer

[turbanoff]

There is only add/iterator/indexOf calls on this list. No removes from the head or something like this. ArrayList should be preferred as more efficient and widely used (more chances for JIT) collection

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302268: Prefer ArrayList to LinkedList in XEmbeddedFramePeer

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• @SWinxy (no known openjdk.org user name / role)
• Damon Nguyen (@DamonGuy - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12486/head:pull/12486
$ git checkout pull/12486

Update a local copy of the PR:
$ git checkout pull/12486
$ git pull https://git.openjdk.org/jdk pull/12486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12486

View PR using the GUI difftool:
$ git pr show -t 12486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12486.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

Looks fine.

[mlbridge]

Webrevs

• 00: Full (21669fdc)

[SWinxy]

As usual I prefer List<> as the type.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302268: Prefer ArrayList to LinkedList in XEmbeddedFramePeer

Reviewed-by: serb, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 239 new commits pushed to the master branch:

• b4ea807: 8288912: vmTestbase/nsk/stress/strace/strace002.java fails with Unexpected method name: currentCarrierThread
• ccf3340: 8303083: (bf) Remove private DirectByteBuffer(long, int) constructor before JDK 21 GA
• 83d77b1: 8303072: Memory leak in exeNullCallerTest.cpp
• 7d8b8ba: 8303131: pandoc.exe mangles all processed html files
• 8f7c496: 8302810: NMT gtests don't correctly check for marked ranges
• 1a07871: 8302173: Button border overlaps with button icon on macOS system LaF
• 796cdd5: 8302677: JFR: Cache label and contentType in EventType and ValueDescriptor
• 6b24b4a: 8302821: JFR: Periodic task thread spins after recording has stopped
• 4d33fbd: 8303089: [jittester] Add time limit to IRTree generation
• f612dcf: 8302512: Update IANA Language Subtag Registry to Version 2023-02-14
• ... and 229 more: https://git.openjdk.org/jdk/compare/a4039e30e8ca85749e6a893ad83e6329471522c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonGuy]

LGTM

[turbanoff]

/integrate

[openjdk]

Going to push as commit 2fb1e3b.
Since your change was applied there have been 243 commits pushed to the master branch:

• 3a9f491: 8301964: Expensive fillInStackTrace operation in HttpURLConnection.getLastModified when no last-modified in response
• 1dbd18a: 8302120: Prefer ArrayList to LinkedList in AggregatePainter
• 2e78d83: 8302899: Executors.newSingleThreadExecutor can use Cleaner to shutdown executor
• 17e3769: 8302871: Speed up StringLatin1.regionMatchesCI
• b4ea807: 8288912: vmTestbase/nsk/stress/strace/strace002.java fails with Unexpected method name: currentCarrierThread
• ccf3340: 8303083: (bf) Remove private DirectByteBuffer(long, int) constructor before JDK 21 GA
• 83d77b1: 8303072: Memory leak in exeNullCallerTest.cpp
• 7d8b8ba: 8303131: pandoc.exe mangles all processed html files
• 8f7c496: 8302810: NMT gtests don't correctly check for marked ranges
• 1a07871: 8302173: Button border overlaps with button icon on macOS system LaF
• ... and 233 more: https://git.openjdk.org/jdk/compare/a4039e30e8ca85749e6a893ad83e6329471522c6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 2fb1e3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.