New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8302152: Speed up tests with infinite loops, sleep less #12514
Conversation
👋 Welcome back epeter! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have several other tests that do the exact same thing (see grep "thread.setDaemon" -r test/hotspot/jtreg/compiler/
). Could you adjust them as well (and update the scope/description of the RFE accordingly)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. You also need to update the copyright dates.
@eme64 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 72 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks @TobiHartmann @vnkozlov for the reviews! |
Going to push as commit a9a53f4.
Your commit was automatically rebased without conflicts. |
From over
5 sec
to about0.8 sec
.I simply reduced the
Thread.sleep
.I verified that the same compilations still happen.
On the time measurement that I got initially reported, this test was flagged as especially long-running, with
17 sec
. There may well be another issue, but I hope this fix already does the trick. We will see this in a while once I get the new data.Update
Did the same for 4 more tests. Always ensured that we still have all compilations.
TestStrangeControl.java
-> reduced from5sec
to2sec
. Needs sleep of1sec
to ensure we still run all compilations as before.TestInfiniteLoopNest.java
-> reduced from5sec
to1.5sec
.TestInfiniteLoopCCP.java
-> reduced from4.5sec
to0.8sec
.TestCMoveWithDeadPhi.java
-> reduced from4.3sec
to0.8sec
.I decided to keep the sleep time rather a bit higher than strictly required. in most of these cases
100ms
would have been sufficient on my machine already.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12514/head:pull/12514
$ git checkout pull/12514
Update a local copy of the PR:
$ git checkout pull/12514
$ git pull https://git.openjdk.org/jdk pull/12514/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12514
View PR using the GUI difftool:
$ git pr show -t 12514
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12514.diff