8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()

[stsypanov]

1. When DateTimeFormatter is reused we don't need to copy availableZoneIds and allocate nonRegionIds as PrefixTree can be taken from cache. In the related benchmark allocation of HashSet takes ~93% of all time, so avoiding it should bring some improvement for cases when we reuse DateTimeFormatter to parse a string into ZoneDateTime
   

2. DateTimeFormatter is mostly used with one locale, so cachedTree and cachedTreeCI can have predefined size.

@State(Scope.Thread)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
public class DateTimeFormatterBenchmark {

    private static final DateTimeFormatter df = new DateTimeFormatterBuilder().appendPattern("yyyy:MM:dd:HH:mm:v").toFormatter();
    private static final String TEXT = "2015:03:10:12:13:ECT";

    @Setup
    public void setUp() {
        ZonedDateTime.parse(TEXT, df);
    }

    @Benchmark
    public ZonedDateTime parse() {
        return ZonedDateTime.parse(TEXT, df);
    }
}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12612/head:pull/12612
$ git checkout pull/12612

Update a local copy of the PR:
$ git checkout pull/12612
$ git pull https://git.openjdk.org/jdk.git pull/12612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12612

View PR using the GUI difftool:
$ git pr show -t 12612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12612.diff

[bridgekeeper]

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stsypanov The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[stsypanov]

Benchmarking

make test TEST="micro:time.format.ZonedDateTimeFormatterBenchmark" MICRO="OPTIONS=-prof gc"

master

Benchmark                                                              Mode  Cnt      Score     Error   Units
ZonedDateTimeFormatterBenchmark.parse                                  avgt   20  13545.737 ± 451.164   ns/op
ZonedDateTimeFormatterBenchmark.parse:·gc.alloc.rate                   avgt   20   1713.579 ±  56.517  MB/sec
ZonedDateTimeFormatterBenchmark.parse:·gc.alloc.rate.norm              avgt   20  24320.006 ±   0.001    B/op
ZonedDateTimeFormatterBenchmark.parse:·gc.count                        avgt   20    110.000            counts
ZonedDateTimeFormatterBenchmark.parse:·gc.time                         avgt   20    514.000                ms


patch

Benchmark                                                              Mode  Cnt     Score    Error   Units
ZonedDateTimeFormatterBenchmark.parse                                  avgt   20  1276.063 ± 52.543   ns/op
ZonedDateTimeFormatterBenchmark.parse:·gc.alloc.rate                   avgt   20   622.223 ± 26.456  MB/sec
ZonedDateTimeFormatterBenchmark.parse:·gc.alloc.rate.norm              avgt   20   832.001 ±  0.001    B/op
ZonedDateTimeFormatterBenchmark.parse:·gc.count                        avgt   20    58.000           counts
ZonedDateTimeFormatterBenchmark.parse:·gc.time                         avgt   20   475.000               ms

[mlbridge]

Webrevs

• 01: Full - Incremental (623a7730)
• 00: Full (b542ae06)

[naotoj]

Looks like a nice fix to me.

[naotoj]

LGTM

[openjdk]

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• d063b89: 8303392: Runtime.exec and ProcessBuilder.start should use System logger
• be764a7: 8302814: Delete unused CountLoopEnd instruct with CmpX
• 34f4d7f: 8304759: Add BitMap iterators
• 42df1a9: 8304991: Redundant hyphen in @param results in double-dash in javadocs
• e3855d0: 8304840: Dangling CharacterCodingException in a few javadoc descriptions
• 6727490: 8303161: [vectorapi] VectorMask.cast narrow operation returns incorrect value with SVE
• f07decb: 8272613: CharsetDecoder.decode(ByteBuffer) throws IllegalArgumentException
• 014c658: 8305086: G1 Redirty Cards phase printed twice
• 2fa0933: 8304990: unnecessary dash in @param gives double-dash in docs
• e56bcb0: 8305095: Update java/net/httpclient/CustomRequestPublisher.java to use new HttpTestServer factory methods
• ... and 54 more: https://git.openjdk.org/jdk/compare/4ec720db9f1fedb5da96e70d1a8c5da5e773a5a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[stsypanov]

/integrate

[openjdk]

@stsypanov
Your change (at version 623a773) is now ready to be sponsored by a Committer.

[naotoj]

/sponsor

[openjdk]

Going to push as commit 438c969.
Since your change was applied there have been 64 commits pushed to the master branch:

• d063b89: 8303392: Runtime.exec and ProcessBuilder.start should use System logger
• be764a7: 8302814: Delete unused CountLoopEnd instruct with CmpX
• 34f4d7f: 8304759: Add BitMap iterators
• 42df1a9: 8304991: Redundant hyphen in @param results in double-dash in javadocs
• e3855d0: 8304840: Dangling CharacterCodingException in a few javadoc descriptions
• 6727490: 8303161: [vectorapi] VectorMask.cast narrow operation returns incorrect value with SVE
• f07decb: 8272613: CharsetDecoder.decode(ByteBuffer) throws IllegalArgumentException
• 014c658: 8305086: G1 Redirty Cards phase printed twice
• 2fa0933: 8304990: unnecessary dash in @param gives double-dash in docs
• e56bcb0: 8305095: Update java/net/httpclient/CustomRequestPublisher.java to use new HttpTestServer factory methods
• ... and 54 more: https://git.openjdk.org/jdk/compare/4ec720db9f1fedb5da96e70d1a8c5da5e773a5a7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj @stsypanov Pushed as commit 438c969.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[olivergillespie]

/backport jdk17u-dev

[openjdk]

@olivergillespie the backport was successfully created on the branch olivergillespie-backport-438c969b in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 438c969b from the openjdk/jdk repository.

The commit being backported was authored by Sergey Tsypanov on 29 Mar 2023 and was reviewed by Naoto Sato.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git olivergillespie-backport-438c969b:olivergillespie-backport-438c969b
$ git checkout olivergillespie-backport-438c969b
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git olivergillespie-backport-438c969b