8300654: Remove JVMFlag::flag_error_str as it is unused

[afshin-zafari]

The function definition and declaration are removed.

Test

mach5 tiers 1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300654: Remove JVMFlag::flag_error_str as it is unused

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12636/head:pull/12636
$ git checkout pull/12636

Update a local copy of the PR:
$ git checkout pull/12636
$ git pull https://git.openjdk.org/jdk pull/12636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12636

View PR using the GUI difftool:
$ git pr show -t 12636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12636.diff

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (73fedf9e)

[dholmes-ora]

Looks good and trivial.

This function has been unused since JDK-8079408 was fixed. I see now that print_flag_error_message_if_needed in writeableFlags.cpp basically replaced the need to map the flag errors directly to strings.

Thanks.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300654: Remove JVMFlag::flag_error_str as it is unused

Reviewed-by: dholmes, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 220 new commits pushed to the master branch:

• 629a905: 8303242: ThreadMXBean issues with virtual threads
• 5b2e2e4: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex)
• cd4b88d: 8292269: Replace FileMapInfo::fail_continue() with Unified Logging
• ae29054: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal
• a04b104: 8303413: (fs) Ignore polling interval sensitivity modifiers in PollingWatchService
• 9944314: 8303587: Remove VMOutOfMemoryError001 test from the problem list after 8303198
• a50dc67: 8303527: update for deprecated sprintf for jdk.hotspot.agent
• 40c5edf: 8303181: Memory leak in ClassLoaderExt::setup_app_search_path
• 29ee7c3: 8303523: Cleanup problem listing of nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java
• e3016c1: 8303472: Display name for region TR
• ... and 210 more: https://git.openjdk.org/jdk/compare/49eb68ba958794fe547cccd00725192cc7063043...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[fparain]

Looks good to me.

[afshin-zafari]

/integrate

[openjdk]

@afshin-zafari
Your change (at version 73fedf9) is now ready to be sponsored by a Committer.

[fparain]

/sponsor

[openjdk]

Going to push as commit 8e20145.
Since your change was applied there have been 232 commits pushed to the master branch:

• bdffe46: 8301222: Generalize check_release_entry in OopStorage
• ec4e8aa: 8303244: G1: call CardTable::clear_MemRegion directly
• 5753ab5: 8297454: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to show opaque button"
• fa1cebe: 8303266: Prefer ArrayList to LinkedList in JImageTask
• 5f153e0: 8302780: Add support for vectorized arraycopy GC barriers
• d00a767: 8295737: macOS: Print content cut off when width > height with portrait orientation
• 15c76e4: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution
• 3eff1a0: 8303630: Move nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java back to general problem list
• 10d6a8e: 8299518: HotSpotVirtualMachine shared code across different platforms
• 148900c: 8303562: Remove obsolete comments in os::pd_attempt_reserve_memory_at
• ... and 222 more: https://git.openjdk.org/jdk/compare/49eb68ba958794fe547cccd00725192cc7063043...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain @afshin-zafari Pushed as commit 8e20145.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.