Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303252: G1: Return early from Full-GC if no regions are selected for compaction. #12768

Closed
wants to merge 8 commits into from
+222 −128
Closed

8303252: G1: Return early from Full-GC if no regions are selected for compaction. #12768

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9bc9062
initial
walulyai Feb 24, 2023
3eb019f
space
walulyai Feb 24, 2023
a5f16b3
copyright years
walulyai Feb 24, 2023
06da84e
trailing whitespace
walulyai Feb 27, 2023
21486e0
Thomas review
walulyai Feb 28, 2023
695f2bd
Albert review
walulyai Mar 1, 2023
3fe10e9
Albert review
walulyai Mar 1, 2023
754ea1a
Remove extra logging
walulyai Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/hotspot/share/gc/g1/g1FullCollector.cpp
View file
Original file line number Diff line number Diff line change
@@ -331,6 +331,7 @@ void G1FullCollector::phase2_prepare_compaction() {
phase2a_determine_worklists();

if (!has_compaction_targets()) {
log_debug(gc, phases)("Phase 2: No compaction targets");
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is useful to add a log message here that no compaction targets were found before exiting. Something like:

log_debug(gc, phases) debug("Phase 2: No compaction targetes");

So that people looking at logs have a better understanding why the other phases are skipped and the next log message will be about phase 5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't log_info(gc, phases) ("No Regions selected for compaction. above (on the info level) already cover this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine for me either way, can keep both or leave just the log_info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log_info one is sufficient.

}