Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8302161: Upgrade jQuery UI to version 1.13.2 #12769

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Feb 27, 2023

Please review an upgrade of the jQuery-UI library to the latest version. There is a security alert with the previous version, but it affects a component that is not part of our custom bundle, so there are no functional changes in this upgrade. I still went ahead with the PR since I already did the work and it's generally good to keep third party code current.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12769/head:pull/12769
$ git checkout pull/12769

Update a local copy of the PR:
$ git checkout pull/12769
$ git pull https://git.openjdk.org/jdk pull/12769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12769

View PR using the GUI difftool:
$ git pr show -t 12769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12769.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2023

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 27, 2023
@openjdk
Copy link

openjdk bot commented Feb 27, 2023

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Feb 27, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2023

Webrevs

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, apart from the one big file, that was easy...

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302161: Upgrade jQuery UI to version 1.13.2

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 119 new commits pushed to the master branch:

  • 4d4eade: 8302452: [JVMCI] Export _poly1305_processBlocks, JfrThreadLocal fields to JVMCI compiler.
  • f1f4e1d: 6453901: (cal) clean up sun.util.calendar classes
  • acf8996: 8303275: Use {@return and @linkplain in Locale and related classes
  • ac3ab5b: 8217496: Matcher.group() can return null after usePattern
  • 45a616a: 8303480: Miscellaneous fixes to mostly invisible doc comments
  • 43288bb: 8301477: Replace NULL with nullptr in os/aix
  • 008c5eb: 8303621: BitMap::iterate should support lambdas and other function objects
  • 52d3008: 8303497: [s390x] ProblemList TestUnreachableInnerLoop.java
  • 3f2d929: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
  • 7fbfc88: 8303534: Merge CompactibleSpace into ContiguousSpace
  • ... and 109 more: https://git.openjdk.org/jdk/compare/fbc036e7454720b589d99a8cae30369a10471528...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2023
@hns
Copy link
Member Author

hns commented Mar 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

Going to push as commit 404d5bd.
Since your change was applied there have been 135 commits pushed to the master branch:

  • d287a5e: 8303617: update for deprecated sprintf for jdk.jdwp.agent
  • ddcb369: 8303605: Memory leaks in Metaspace gtests
  • 56512cf: 8303682: Simplify HttpClient DebugLogger
  • 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
  • d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
  • afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
  • 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
  • 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
  • 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
  • 5fa9bd4: 8302189: Mark assertion failures noreturn
  • ... and 125 more: https://git.openjdk.org/jdk/compare/fbc036e7454720b589d99a8cae30369a10471528...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2023
@openjdk openjdk bot closed this Mar 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2023
@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@hns Pushed as commit 404d5bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants