8303261: JFR: jdk/jfr/api/consumer/streaming/TestJVMCrash.java doesn't retry

[egahlin]

Could I have review of this test fix. Problem is that an exception is thrown when the TestProcess class tries to access the repository and the process is not available. It's unclear why this is the case, but it leads to an exception, which exits the test retry lopp. Fix is to catch the exception, print the message and retry.

Testing. 100 * jdk/jfr/api/consumer/streaming/TestJVMCrash.java

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303261: JFR: jdk/jfr/api/consumer/streaming/TestJVMCrash.java doesn't retry

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12776/head:pull/12776
$ git checkout pull/12776

Update a local copy of the PR:
$ git checkout pull/12776
$ git pull https://git.openjdk.org/jdk pull/12776/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12776

View PR using the GUI difftool:
$ git pr show -t 12776

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12776.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (00493a25)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303261: JFR: jdk/jfr/api/consumer/streaming/TestJVMCrash.java doesn't retry

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 5feb13b: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
• 1e3c9fd: 8026369: javac potentially ambiguous overload warning needs an improved scheme
• 14a014d: 8302124: HotSpot Style Guide should permit noreturn attribute
• bca60f4: 8303249: JFR: Incorrect description of dumponexit
• f7f1036: 8303068: Memory leak in DwarfFile::LineNumberProgram::run_line_number_program
• 784f7b1: 8293667: Align jlink's --compress option with jmod's --compress option
• 54603aa: 8303208: JFR: 'jfr print' displays incorrect timestamps
• 4c169d2: 8303253: Remove unnecessary calls to super() in java.time value based classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 6423065.
Since your change was applied there have been 12 commits pushed to the master branch:

• dc5ea6a: 8303350: Fix mistyped {@code}
• 4a415ad: 8303351: [IR Framework] Add missing cpu feature avx512bw after JDK-8302681
• 30302d1: 8303250: Call ct_max_alignment_constraint using the base class
• e144783: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
• 5feb13b: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
• 1e3c9fd: 8026369: javac potentially ambiguous overload warning needs an improved scheme
• 14a014d: 8302124: HotSpot Style Guide should permit noreturn attribute
• bca60f4: 8303249: JFR: Incorrect description of dumponexit
• f7f1036: 8303068: Memory leak in DwarfFile::LineNumberProgram::run_line_number_program
• 784f7b1: 8293667: Align jlink's --compress option with jmod's --compress option
• ... and 2 more: https://git.openjdk.org/jdk/compare/b527edd3388ad6a0d44a291983b08b2b5c023f8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 6423065.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.