8274264: Not all of G1 young collection verification honors the verification type

[ahmedmuhsin]

Checking whether verification is required before running any of the verification steps.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8274264: Not all of G1 young collection verification honors the verification type

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12818/head:pull/12818
$ git checkout pull/12818

Update a local copy of the PR:
$ git checkout pull/12818
$ git pull https://git.openjdk.org/jdk pull/12818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12818

View PR using the GUI difftool:
$ git pr show -t 12818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12818.diff

[bridgekeeper]

👋 Welcome back ahmedmuhsin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ahmedmuhsin The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[ahmedmuhsin]

There is one failure in the pre-submit tests which I believe is unrelated to this change:
compiler/vectorization/runner/LoopRangeStrideTest.java

TEST RESULT: Failed. Execution failed: `main' threw exception: compiler.lib.ir_framework.driver.irmatching.IRViolationException: There were one or multiple IR rule failures. Please check stderr for more information.

[mlbridge]

Webrevs

• 00: Full (a14e6c6c)

[openjdk]

@ahmedmuhsin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274264: Not all of G1 young collection verification honors the verification type

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

• f813dc7: 8302508: Add timestamp to the output TraceCompilerThreads
• 404d5bd: 8302161: Upgrade jQuery UI to version 1.13.2
• d287a5e: 8303617: update for deprecated sprintf for jdk.jdwp.agent
• ddcb369: 8303605: Memory leaks in Metaspace gtests
• 56512cf: 8303682: Simplify HttpClient DebugLogger
• 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
• d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• ... and 88 more: https://git.openjdk.org/jdk/compare/6e19387f29944aa9d5c82bf0ece3abf0ca53b39c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[tschatzl]

Lgtm.

[ahmedmuhsin]

/integrate

[openjdk]

@ahmedmuhsin
Your change (at version a14e6c6) is now ready to be sponsored by a Committer.

[tschatzl]

/sponsor

[openjdk]

Going to push as commit 34a9246.
Since your change was applied there have been 108 commits pushed to the master branch:

• a7e308a: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• dd79410: 8303509: Socket setTrafficClass does not work for IPv4 connections when IPv6 enabled
• dc523a5: 8300258: C2: vectorization fails on simple ByteBuffer loop
• 5e232cf: 8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi
• 8cfd74f: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter
• 02875e7: 8171156: Class java.util.LocaleISOData has outdated information for country Code NP
• ad326fc: 8299570: [JVMCI] Insufficient error handling when CodeBuffer is exhausted
• 05ceb37: 8303833: java.util.LocaleISOData has wrong comments for 'Norwegian Bokmål' and 'Volapük'
• 25de222: 8303839: [BACKOUT] JDK-8302799 and JDK-8302189
• 5b43804: 8282201: Consider removal of expiry check in VerifyCACerts.java test
• ... and 98 more: https://git.openjdk.org/jdk/compare/6e19387f29944aa9d5c82bf0ece3abf0ca53b39c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl @ahmedmuhsin Pushed as commit 34a9246.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.