Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8303575: adjust Xen handling on Linux aarch64 #12853

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 3, 2023

After JDK-8301050 the Xen handling on aarch64 should be slightly adjusted.
The output in VM_Version::print_platform_virtualization_info was missed and needs to be added for Xen.
Additionally a new XenPVHVM virtualization type could be introduced because this describes the Xen on aarch64 better.
See also https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/virtualization-on-arm-with-xen where the naming is used.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12853/head:pull/12853
$ git checkout pull/12853

Update a local copy of the PR:
$ git checkout pull/12853
$ git pull https://git.openjdk.org/jdk pull/12853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12853

View PR using the GUI difftool:
$ git pr show -t 12853

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12853.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 3, 2023
@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 3, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2023

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303575: adjust Xen handling on Linux aarch64

Reviewed-by: lucy, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

  • d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
  • afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
  • 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
  • 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
  • 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
  • 5fa9bd4: 8302189: Mark assertion failures noreturn
  • 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
  • d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • 5f1108f: 8303151: DCmd framework cleanups
  • 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
  • ... and 58 more: https://git.openjdk.org/jdk/compare/339ca887835d6456da9fcccdc32fb7716cbc60bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2023
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MBaesken
Copy link
Member Author

MBaesken commented Mar 8, 2023

Hi Martin and Lutz, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

Going to push as commit 8eaf84f.
Since your change was applied there have been 68 commits pushed to the master branch:

  • d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
  • afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
  • 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
  • 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
  • 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
  • 5fa9bd4: 8302189: Mark assertion failures noreturn
  • 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
  • d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • 5f1108f: 8303151: DCmd framework cleanups
  • 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
  • ... and 58 more: https://git.openjdk.org/jdk/compare/339ca887835d6456da9fcccdc32fb7716cbc60bb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2023
@openjdk openjdk bot closed this Mar 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2023
@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@MBaesken Pushed as commit 8eaf84f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants