Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null #12886

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Mar 6, 2023

Could I have a review of a PR that removes an Objects.requireNonNull from the setMaxAge method in the RemoteRecordingStream class. The check was accidentally added when the class was introduced in JDK 16. The specification states that null is accepted (similar to the Recording class). Max age is by default null, but can be set to another duration, for example Duration.ofHours(1), but not set back to null without this change.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12886/head:pull/12886
$ git checkout pull/12886

Update a local copy of the PR:
$ git checkout pull/12886
$ git pull https://git.openjdk.org/jdk pull/12886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12886

View PR using the GUI difftool:
$ git pr show -t 12886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12886.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Mar 6, 2023
@egahlin egahlin marked this pull request as ready for review March 6, 2023 19:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 43288bb: 8301477: Replace NULL with nullptr in os/aix
  • 008c5eb: 8303621: BitMap::iterate should support lambdas and other function objects
  • 52d3008: 8303497: [s390x] ProblemList TestUnreachableInnerLoop.java
  • 3f2d929: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
  • 7fbfc88: 8303534: Merge CompactibleSpace into ContiguousSpace
  • 97c25df: 8204550: NMT: RegionIterator does not need to keep _current_size
  • 94eda53: 8201516: DebugNonSafepoints generates incorrect information
  • c51d40c: 8303607: SunMSCAPI provider leaks memory and keys
  • f64ed09: 8303540: Eliminate unnecessary reference to javac internal class
  • ccfe167: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test
  • ... and 1 more: https://git.openjdk.org/jdk/compare/a97271e3b5d5a08fc503a11cd3e253974fb77ce6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2023
@egahlin
Copy link
Member Author

egahlin commented Mar 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

Going to push as commit 32f4d8b.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
  • b5b5cba: 8302801: Remove fdlibm C sources
  • 4d4eade: 8302452: [JVMCI] Export _poly1305_processBlocks, JfrThreadLocal fields to JVMCI compiler.
  • f1f4e1d: 6453901: (cal) clean up sun.util.calendar classes
  • acf8996: 8303275: Use {@return and @linkplain in Locale and related classes
  • ac3ab5b: 8217496: Matcher.group() can return null after usePattern
  • 45a616a: 8303480: Miscellaneous fixes to mostly invisible doc comments
  • 43288bb: 8301477: Replace NULL with nullptr in os/aix
  • 008c5eb: 8303621: BitMap::iterate should support lambdas and other function objects
  • 52d3008: 8303497: [s390x] ProblemList TestUnreachableInnerLoop.java
  • ... and 8 more: https://git.openjdk.org/jdk/compare/a97271e3b5d5a08fc503a11cd3e253974fb77ce6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2023
@openjdk openjdk bot closed this Mar 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2023
@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@egahlin Pushed as commit 32f4d8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants