New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null #12886
Conversation
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
Webrevs
|
@egahlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 32f4d8b.
Your commit was automatically rebased without conflicts. |
Could I have a review of a PR that removes an Objects.requireNonNull from the setMaxAge method in the RemoteRecordingStream class. The check was accidentally added when the class was introduced in JDK 16. The specification states that null is accepted (similar to the Recording class). Max age is by default null, but can be set to another duration, for example Duration.ofHours(1), but not set back to null without this change.
Testing: jdk/jdk/jfr
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12886/head:pull/12886
$ git checkout pull/12886
Update a local copy of the PR:
$ git checkout pull/12886
$ git pull https://git.openjdk.org/jdk pull/12886/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12886
View PR using the GUI difftool:
$ git pr show -t 12886
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12886.diff