8303105: LoopRangeStrideTest fails IR verification on x86

[jatin-bhateja]

SLP fails to recognize valid address expression during SWPointer creation for memory operands with 32 bit jvm, this prevents gathering adjacent memory operations.
Debug trace with -XX:+TraceSuperWord -XX:+TraceNewVectors -XX:CompileCommand=VectorizeDebug,,3 shows following errors .

SWPointer::memory_alignment: SWPointer p invalid, return bottom_align
SWPointer::memory_alignment: SWPointer p invalid, return bottom_align
SWPointer::memory_alignment: SWPointer p invalid, return bottom_align
SWPointer::memory_alignment: SWPointer p invalid, return bottom_align
SWPointer::memory_alignment: SWPointer p invalid, return bottom_align

Problem also exist in JDK17 LTS. As an interim solution to prevent this showing up as a GHA test failure, we can enable the test only for x86_64 and aarch64 targets. Difference in address expression b/w X86 32 and 64 bit jvm will be root caused in follow issue JDK-8303885.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303105: LoopRangeStrideTest fails IR verification on x86

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12938/head:pull/12938
$ git checkout pull/12938

Update a local copy of the PR:
$ git checkout pull/12938
$ git pull https://git.openjdk.org/jdk pull/12938/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12938

View PR using the GUI difftool:
$ git pr show -t 12938

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12938.diff

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jatin-bhateja The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e6d0983f)

[TobiHartmann]

Looks good and trivial.

[openjdk]

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303105: LoopRangeStrideTest fails IR verification on x86

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 34a9246: 8274264: Not all of G1 young collection verification honors the verification type

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jatin-bhateja]

Thanks @TobiHartmann , integrating it.

[jatin-bhateja]

/integrate

[openjdk]

Going to push as commit 713def0.
Since your change was applied there has been 1 commit pushed to the master branch:

• 34a9246: 8274264: Not all of G1 young collection verification honors the verification type

Your commit was automatically rebased without conflicts.

[openjdk]

@jatin-bhateja Pushed as commit 713def0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.