New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8303822: gtestMain should give more helpful output #12940
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Hi Leonid, thanks for the review ! /integrate |
Going to push as commit 0f26d09.
Your commit was automatically rebased without conflicts. |
When the JDK to test is not provided, gtestMain currently prints something like this :
./hotspot/variant-server/libjvm/gtest/gtestLauncher
ERROR: You must specify a JDK to use for running the unit tests.
The output could be improved, might be helpful for occasional users, e.g.
ERROR: You must specify a JDK (-jdk <image>, --jdk=<image> or -jdk:<image>) to use for running the unit tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12940/head:pull/12940
$ git checkout pull/12940
Update a local copy of the PR:
$ git checkout pull/12940
$ git pull https://git.openjdk.org/jdk pull/12940/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12940
View PR using the GUI difftool:
$ git pr show -t 12940
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12940.diff