Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304015: G1: Metaspace-induced GCs should not trigger maximal compaction #12987

Closed
wants to merge 2 commits into from
+4 −6
Closed

8304015: G1: Metaspace-induced GCs should not trigger maximal compaction #12987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcda41a
clear_all_soft_refs shouldn't always trigger full compaction
walulyai Mar 9, 2023
be9760b
not an explicit GC
walulyai Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/hotspot/share/gc/g1/g1CollectedHeap.cpp
View file
Original file line number Diff line number Diff line change
@@ -1065,12 +1065,10 @@ void G1CollectedHeap::do_full_collection(bool clear_all_soft_refs) {
// Currently, there is no facility in the do_full_collection(bool) API to notify
// the caller that the collection did not succeed (e.g., because it was locked
// out by the GC locker). So, right now, we'll ignore the return value.
// When clear_all_soft_refs is set we want to do a maximal compaction
// not leaving any dead wood.
bool do_maximal_compaction = clear_all_soft_refs;
bool dummy = do_full_collection(true, /* explicit_gc */
clear_all_soft_refs,
do_maximal_compaction);

do_full_collection(false, /* explicit_gc */
clear_all_soft_refs,
false /* do_maximal_compaction */);
}

bool G1CollectedHeap::upgrade_to_full_collection() {