Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode #12990

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Mar 11, 2023

Trivial fixes to ProblemList 3 different tests:
JDK-8304017 ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
JDK-8304018 ProblemList javax/swing/JColorChooser/Test6827032.java on windows-x64
JDK-8304019 ProblemList java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java on windows-x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
  • JDK-8304018: ProblemList javax/swing/JColorChooser/Test6827032.java on windows-x64
  • JDK-8304019: ProblemList java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java on windows-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12990/head:pull/12990
$ git checkout pull/12990

Update a local copy of the PR:
$ git checkout pull/12990
$ git pull https://git.openjdk.org/jdk pull/12990/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12990

View PR using the GUI difftool:
$ git pr show -t 12990

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12990.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8304017
/issue JDK-8304018
/issue JDK-8304019

/label add hotspot-runtime
/label add serviceability
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review March 11, 2023 17:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2023
@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8304018: ProblemList javax/swing/JColorChooser/Test6827032.java on windows-x64.

@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8304019: ProblemList java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java on windows-x64.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 11, 2023
@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Mar 11, 2023
@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 11, 2023
@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 11, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial

@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
8304018: ProblemList javax/swing/JColorChooser/Test6827032.java on windows-x64
8304019: ProblemList java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java on windows-x64

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2023
@dcubed-ojdk
Copy link
Member Author

@tstuefe - Thanks for the fast review and especially on a Saturday!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2023

Going to push as commit fbc76c2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2023
@openjdk openjdk bot closed this Mar 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2023
@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@dcubed-ojdk Pushed as commit fbc76c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8304017 branch March 11, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants