8298995: tools/jpackage/share/AddLauncherTest.java#id1 failed "AddLauncherTest.test; checks=53"

[sashamatveev]

This is similar to many other issues we had with hdiutil failures. Fixed in similar way by repeating hdiutil command. Cannot confirm that it will resolve this issue, but similar issues got resolved by repeating command. Also, switched writing output from hdiutil to file. It is known issue that execution of hdiutil can hang if output is not written to file.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298995: tools/jpackage/share/AddLauncherTest.java#id1 failed "AddLauncherTest.test; checks=53"

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13002/head:pull/13002
$ git checkout pull/13002

Update a local copy of the PR:
$ git checkout pull/13002
$ git pull https://git.openjdk.org/jdk pull/13002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13002

View PR using the GUI difftool:
$ git pr show -t 13002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13002.diff

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sashamatveev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (72c9094b)

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298995: tools/jpackage/share/AddLauncherTest.java#id1 failed "AddLauncherTest.test; checks=53"

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 149 new commits pushed to the master branch:

• 254288a: 8014021: TreeMaker.Params behaves inconsistently when the owning method has the same number of parameters as the number of parameter types requested
• 8f5bb53: 8015831: Add lint check for calling overridable methods from a constructor
• b085ab9: 8180387: com.sun.source.util.JavacTask should have a protected constructor.
• bfb812a: 8292818: replace 96-bit representation for field metadata with variable-sized streams
• 932be35: 8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders
• 02a4ee2: 8303921: serviceability/sa/UniqueVtableTest.java timed out
• 4486f1b: 8304367: jlink --include-locales=* attempts to parse non .class resource files with classfile reader
• 8d2ebf2: 8303697: ProcessTools doesn't print last line of process output
• d5a1507: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
• 384a8b8: 8303069: Memory leak in CompilerOracle::parse_from_line
• ... and 139 more: https://git.openjdk.org/jdk/compare/21a6ab1e3ea5228a31955d58fe75e5ae66d1c6cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

Going to push as commit c56f011.
Since your change was applied there have been 149 commits pushed to the master branch:

• 254288a: 8014021: TreeMaker.Params behaves inconsistently when the owning method has the same number of parameters as the number of parameter types requested
• 8f5bb53: 8015831: Add lint check for calling overridable methods from a constructor
• b085ab9: 8180387: com.sun.source.util.JavacTask should have a protected constructor.
• bfb812a: 8292818: replace 96-bit representation for field metadata with variable-sized streams
• 932be35: 8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders
• 02a4ee2: 8303921: serviceability/sa/UniqueVtableTest.java timed out
• 4486f1b: 8304367: jlink --include-locales=* attempts to parse non .class resource files with classfile reader
• 8d2ebf2: 8303697: ProcessTools doesn't print last line of process output
• d5a1507: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
• 384a8b8: 8303069: Memory leak in CompilerOracle::parse_from_line
• ... and 139 more: https://git.openjdk.org/jdk/compare/21a6ab1e3ea5228a31955d58fe75e5ae66d1c6cd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sashamatveev Pushed as commit c56f011.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.