Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304411: Remove unused CardTable::clear #13075

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 17, 2023

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13075/head:pull/13075
$ git checkout pull/13075

Update a local copy of the PR:
$ git checkout pull/13075
$ git pull https://git.openjdk.org/jdk pull/13075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13075

View PR using the GUI difftool:
$ git pr show -t 13075

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13075.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8304411 8304411: Remove unused CardTable::clear Mar 17, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 17, 2023
@openjdk
Copy link

openjdk bot commented Mar 17, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 17, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk
Copy link

openjdk bot commented Mar 17, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304411: Remove unused CardTable::clear

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 4486f1b: 8304367: jlink --include-locales=* attempts to parse non .class resource files with classfile reader
  • 8d2ebf2: 8303697: ProcessTools doesn't print last line of process output
  • d5a1507: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
  • 384a8b8: 8303069: Memory leak in CompilerOracle::parse_from_line
  • 6dd6c15: 8301684: Fix test code to not get finalizer deprecation warnings
  • cb4ae19: 8292059: Do not inline InstanceKlass::allocate_instance()
  • b2639e1: 8304164: jdk/classfile/CorpusTest.java still fails after JDK-8303910
  • 620564a: 8304130: Add runtime/StackGuardPages/TestStackGuardPagesNative.java to ProblemList.txt
  • 9d518c5: 8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp
  • ebac7ee: 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH
  • ... and 6 more: https://git.openjdk.org/jdk/compare/96889bf3e4f36fa7f9e9b9989a1bc3ac4719bfeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 17, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2023

Going to push as commit 652bda0.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 4505670: 8304174: Remove delays from httpserver tests
  • c09f83e: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1
  • e339e18: 7016187: javac -h could generate conflict .h for inner class and class name with '_'
  • 033c0b1: 8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC
  • 7503ecc: 8304138: [JVMCI] Test FailedSpeculation existence before appending.
  • f8482c2: 8297638: Memory leak in case of many started-dead threads
  • c56f011: 8298995: tools/jpackage/share/AddLauncherTest.java#id1 failed "AddLauncherTest.test; checks=53"
  • 254288a: 8014021: TreeMaker.Params behaves inconsistently when the owning method has the same number of parameters as the number of parameter types requested
  • 8f5bb53: 8015831: Add lint check for calling overridable methods from a constructor
  • b085ab9: 8180387: com.sun.source.util.JavacTask should have a protected constructor.
  • ... and 19 more: https://git.openjdk.org/jdk/compare/96889bf3e4f36fa7f9e9b9989a1bc3ac4719bfeb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2023
@openjdk openjdk bot closed this Mar 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2023
@openjdk
Copy link

openjdk bot commented Mar 20, 2023

@albertnetymk Pushed as commit 652bda0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the remove-ct-clear branch March 20, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants