8304541: Modules THROW_MSG_ should return nullptr instead of JNI_FALSE

[TheShermanTanker]

Cleanup in NPE code to return a proper nullptr instead of JNI_FALSE. JNI_FALSE expands to 0, which technically works as a null pointer here, but this becomes pretty confusing and strange when reading through the code

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304541: Modules THROW_MSG_ should return nullptr instead of JNI_FALSE

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13105/head:pull/13105
$ git checkout pull/13105

Update a local copy of the PR:
$ git checkout pull/13105
$ git pull https://git.openjdk.org/jdk.git pull/13105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13105

View PR using the GUI difftool:
$ git pr show -t 13105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13105.diff

[bridgekeeper]

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheShermanTanker The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d4f22886)

[coleenp]

Looks good, also trivial. I'm surprised there weren't more of these.

[openjdk]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304541: Modules THROW_MSG_ should return nullptr instead of JNI_FALSE

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheShermanTanker]

Thanks Coleen!

[TheShermanTanker]

/integrate

[openjdk]

Going to push as commit 19f2edd.

[openjdk]

@TheShermanTanker Pushed as commit 19f2edd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.