Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8304683: Memory leak in WB_IsMethodCompatible #13124

Closed
wants to merge 1 commit into from

Conversation

jcking
Copy link
Contributor

@jcking jcking commented Mar 21, 2023

Add missing call to DirectivesStack::release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13124/head:pull/13124
$ git checkout pull/13124

Update a local copy of the PR:
$ git checkout pull/13124
$ git pull https://git.openjdk.org/jdk.git pull/13124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13124

View PR using the GUI difftool:
$ git pr show -t 13124

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13124.diff

Signed-off-by: Justin King <jcking@google.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2023

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

@jcking The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 21, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Mar 22, 2023

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304683: Memory leak in WB_IsMethodCompatible

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0156909: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved
  • 0deb648: 8290200: com/sun/jdi/InvokeHangTest.java fails with "Debuggee appears to be hung"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2023
@jcking
Copy link
Contributor Author

jcking commented Mar 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2023

Going to push as commit 760c012.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
  • 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
  • ddf1e34: 8304089: Convert TraceDependencies to UL
  • 358c61b: 8294972: Convert jdk.jlink internal plugins to use the Classfile API
  • c74507e: 8304657: G1: Rename set_state_empty to set_state_untracked
  • ca94287: 8304144: G1: Remove unnecessary is_survivor check in G1ClearCardTableTask
  • eda0065: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659
  • c039d26: 8303804: Fix some errors of If-VectorTest and CMove-VectorTest
  • 0156909: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved
  • 0deb648: 8290200: com/sun/jdi/InvokeHangTest.java fails with "Debuggee appears to be hung"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2023
@openjdk openjdk bot closed this Mar 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2023
@openjdk
Copy link

openjdk bot commented Mar 22, 2023

@jcking Pushed as commit 760c012.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants