8304802: After JDK-8297639 the flag G1UsePreventiveGC needs to be added to the obsoletion table

[tschatzl]

Hi all,

please review this change that puts the G1UsePreventiveGC into the argument obsoletion table so that the appropriate warning is printed when starting the VM with that option. Functionality has already been removed , and CSR request approved with JDK-8297639.

(Edit: no CSR request required because this was a diagnostic flag)

Testing: local compilation, manual testing that the obsoletion warning is printed on the command line.

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304802: After JDK-8297639 the flag G1UsePreventiveGC needs to be added to the obsoletion table

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 32410e72
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 32410e72

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13156/head:pull/13156
$ git checkout pull/13156

Update a local copy of the PR:
$ git checkout pull/13156
$ git pull https://git.openjdk.org/jdk.git pull/13156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13156

View PR using the GUI difftool:
$ git pr show -t 13156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13156.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (017f2e8c)
• 00: Full (32410e72)

[tschatzl]

/label add hotspot-gc

[openjdk]

@tschatzl
The hotspot-gc label was successfully added.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304802: After JDK-8297639 the flag G1UsePreventiveGC needs to be added to the obsoletion table

Reviewed-by: ayang, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 941a7ac: 8304301: Remove the global option SuperWordMaxVectorSize
• ac6af6a: 7176515: ExceptionInInitializerError for an enum with multiple switch statements
• dd23ee9: 8303917: Update ISO 639 language codes table
• 6f67abd: 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out
• 568dd57: 8304716: Clean up G1Policy::calc_max_old_cset_length()
• af0504e: 8304691: Remove jlink --post-process-path option
• 3859faf: 8231349: Move intrinsic stubs generation to compiler runtime initialization code
• f37674a: 8304711: Combine G1 root region abort and wait into a single method
• 7f9e691: 8304712: Only pass total number of regions into G1Policy::calc_min_old_cset_length
• 51035a7: 8294137: Review running times of java.math tests
• ... and 19 more: https://git.openjdk.org/jdk/compare/c74507eeb3c6b744b144e241373b109548624121...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

This set of bugs is very confusing, but I'm not seeing the CSR request you mentioned that allowed these flags to be deprecated, then obsoleted. ??

[dholmes-ora]

Ah never mind - it is a diagnostic flag so no CSR needed anyway.

Looks good. Thanks

[tschatzl]

Thanks @dholmes-ora @albertnetymk for your reviews

/integrate

[openjdk]

Going to push as commit 13dd19a.
Since your change was applied there have been 30 commits pushed to the master branch:

• d61de14: 8303508: Vector.lane() gets wrong value on x86
• 941a7ac: 8304301: Remove the global option SuperWordMaxVectorSize
• ac6af6a: 7176515: ExceptionInInitializerError for an enum with multiple switch statements
• dd23ee9: 8303917: Update ISO 639 language codes table
• 6f67abd: 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out
• 568dd57: 8304716: Clean up G1Policy::calc_max_old_cset_length()
• af0504e: 8304691: Remove jlink --post-process-path option
• 3859faf: 8231349: Move intrinsic stubs generation to compiler runtime initialization code
• f37674a: 8304711: Combine G1 root region abort and wait into a single method
• 7f9e691: 8304712: Only pass total number of regions into G1Policy::calc_min_old_cset_length
• ... and 20 more: https://git.openjdk.org/jdk/compare/c74507eeb3c6b744b144e241373b109548624121...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 13dd19a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.