Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads #13351

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 5, 2023

A trivial fix to ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13351/head:pull/13351
$ git checkout pull/13351

Update a local copy of the PR:
$ git checkout pull/13351
$ git pull https://git.openjdk.org/jdk.git pull/13351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13351

View PR using the GUI difftool:
$ git pr show -t 13351

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13351.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review April 5, 2023 13:52
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@dcubed-ojdk
The serviceability label was successfully added.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with now updated bug id.

@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • f69d88c: 8301616: Drag & maximize to another monitor places window incorrectly (Windows)
  • a3137c7: 8305646: compile error on Alpine with gcc12 after 8298619 in libGetXSpace.c
  • 78ff454: 8305490: CommandProcessor command "dumpclass" produces classes with invalid field descriptors
  • 9f587d2: 8305644: IGV: Node text not updated when switching from/to CFG view
  • 4bf1987: 8296454: System.console() shouldn't return null in jshell
  • 2aec910: 8304883: Record Deconstruction causes bytecode error
  • 0e0c022: 8305356: Fix ignored bad CompileCommands in tests
  • b659c35: 8068824: Exception thrown in JTableHeader after clicking on popupmenu opened with right-click on header
  • 83a924a: 8304042: C2 SuperWord: schedule must remove packs with cyclic dependencies
  • 0ec3d2e: 7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.
  • ... and 7 more: https://git.openjdk.org/jdk/compare/dd59471798ad0118481939c59e58eca18e4365d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 5, 2023
@dcubed-ojdk
Copy link
Member Author

@TobiHartmann - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2023

Going to push as commit 2e59d21.
Since your change was applied there have been 17 commits pushed to the master branch:

  • f69d88c: 8301616: Drag & maximize to another monitor places window incorrectly (Windows)
  • a3137c7: 8305646: compile error on Alpine with gcc12 after 8298619 in libGetXSpace.c
  • 78ff454: 8305490: CommandProcessor command "dumpclass" produces classes with invalid field descriptors
  • 9f587d2: 8305644: IGV: Node text not updated when switching from/to CFG view
  • 4bf1987: 8296454: System.console() shouldn't return null in jshell
  • 2aec910: 8304883: Record Deconstruction causes bytecode error
  • 0e0c022: 8305356: Fix ignored bad CompileCommands in tests
  • b659c35: 8068824: Exception thrown in JTableHeader after clicking on popupmenu opened with right-click on header
  • 83a924a: 8304042: C2 SuperWord: schedule must remove packs with cyclic dependencies
  • 0ec3d2e: 7124527: [macosx] SwingSet2, label is not read by VoiceOver when focus is on textfield for Internalframe and Table demo.
  • ... and 7 more: https://git.openjdk.org/jdk/compare/dd59471798ad0118481939c59e58eca18e4365d1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2023
@openjdk openjdk bot closed this Apr 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@dcubed-ojdk Pushed as commit 2e59d21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 5, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8305659 branch April 5, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants