New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8304825: MacOS metal pipeline - window isn't painted if created during display sleep #13375
Conversation
👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into |
J2dTraceLn(J2D_TRACE_VERBOSE, "MTLLayer.onScreenSleep --- received screen sleep notification."); | ||
|
||
[self stopDisplayLink]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is something we should have done already to save wasted work ?
i.e if the screen is asleep, we don't need to be connected to it and updating windows ?
But I see the same stopDisplayLink call in the wakeup code ... any issues with the extra call there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is something we should have done already to save wasted work ?
i.e if the screen is asleep, we don't need to be connected to it and updating windows ?
We start the DisplayLink from Metal RenderQueue whenever there is something to be painted from back buffer to the window buffer. Once the window buffer is painted in a DisplayLink callback, we stop the DisplayLink.
We were not stopping the DisplayLink on screen sleep event. This is what this PR adds.
But I see the same stopDisplayLink call in the wakeup code ... any issues with the extra call there ?
I have added that call as a sanity before releasing the Displaylink. It will be a no-op if DisplayLink is not running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I tested this on an M1 MacBook. The test program attached to the bug fails without your fix and passes with your fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
@aghaisas This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 127 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 969a6b9.
Your commit was automatically rebased without conflicts. |
Root cause : The CVDisplayLink used in MTLLayer stops invoking callbacks on screen sleep and wakeup event. It is found that stop and restart of CVDisplayLink on these events also does not help.
Fix : Recreate the CVDisplayLink on screen sleep and wakeup event.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13375/head:pull/13375
$ git checkout pull/13375
Update a local copy of the PR:
$ git checkout pull/13375
$ git pull https://git.openjdk.org/jdk.git pull/13375/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13375
View PR using the GUI difftool:
$ git pr show -t 13375
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13375.diff
Webrev
Link to Webrev Comment