8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack

src/hotspot/share/opto/matcher.hpp

@@ -88,6 +88,7 @@ class Matcher : public PhaseTransform {
   // Private arena of State objects
   ResourceArea _states_arena;
 
+  // Map old nodes to new nodes
   Node_List   _new_nodes;
 
   VectorSet   _visited;         // Visit bits

src/hotspot/share/opto/phaseX.cpp

@@ -429,7 +429,7 @@ PhaseRenumberLive::PhaseRenumberLive(PhaseGVN* gvn,
     C->grow_node_notes(C->node_note_array(), new_size);
   }
 
-  assert(worklist.is_subset_of(_useful), "sanity");
+  assert(worklist.is_subset_of(_useful), "only useful nodes should still be in the worklist");
 
   // Iterate over the set of live nodes.
   for (uint current_idx = 0; current_idx < _useful.size(); current_idx++) {

src/hotspot/share/opto/phaseX.hpp

@@ -25,14 +25,14 @@
 #ifndef SHARE_OPTO_PHASEX_HPP
 #define SHARE_OPTO_PHASEX_HPP
 
-#include "utilities/globalDefinitions.hpp"
 #include "libadt/dict.hpp"
 #include "libadt/vectset.hpp"
 #include "memory/resourceArea.hpp"
 #include "opto/memnode.hpp"
 #include "opto/node.hpp"
 #include "opto/phase.hpp"
 #include "opto/type.hpp"
+#include "utilities/globalDefinitions.hpp"
 
 class BarrierSetC2;
 class Compile;