Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64 #14106

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 23, 2023

Trivial fixes to ProblemList some tests:
JDK-8308716 ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
JDK-8308718 ProblemList three mlvm/indy/func/jvmti tests on windows-x64 in Xcomp mode
JDK-8308720 ProblemList java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java on macosx-x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
  • JDK-8308718: ProblemList three mlvm/indy/func/jvmti tests on windows-x64 in Xcomp mode
  • JDK-8308720: ProblemList java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java on macosx-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14106/head:pull/14106
$ git checkout pull/14106

Update a local copy of the PR:
$ git checkout pull/14106
$ git pull https://git.openjdk.org/jdk.git pull/14106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14106

View PR using the GUI difftool:
$ git pr show -t 14106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14106.diff

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…/BasicCancelTest.java with genzgc on windows-x64
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler
label add core-libs
/label add client

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8308716
/issue JDK-8308718
/issue JDK-8308720

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk
The client label was successfully added.

@openjdk openjdk bot changed the title Jdk 8308716 8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64 May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8308718: ProblemList three mlvm/indy/func/jvmti tests on windows-x64 in Xcomp mode.

@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8308720: ProblemList java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java on macosx-x64.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk
The hotspot-gc label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 23, 2023 20:36
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308716: ProblemList java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java with genzgc on windows-x64
8308718: ProblemList three mlvm/indy/func/jvmti tests on windows-x64 in Xcomp mode
8308720: ProblemList java/awt/event/SequencedEvent/MultipleContextsFunctionalTest.java on macosx-x64

Reviewed-by: azvegint, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2023
@dcubed-ojdk
Copy link
Member Author

@azvegint and @jddarcy - Thanks for the fast reviews!

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2023

Going to push as commit ed0e956.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2023
@openjdk openjdk bot closed this May 23, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 23, 2023
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@dcubed-ojdk Pushed as commit ed0e956.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented May 23, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8308716 branch May 23, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants