Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311180: Remove unused unneeded definitions from globalDefinitions #14737

Closed
wants to merge 3 commits into from
+6 −23
Closed

8311180: Remove unused unneeded definitions from globalDefinitions #14737

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44fb472
8311180: Remove unused unneeded definitions from globalDefinitions
coleenp Jun 30, 2023
6725b46
Fix ppc
coleenp Jun 30, 2023
d28d9ea
This should be uintptr_t.
coleenp Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/cpu/ppc/icache_ppc.hpp
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2002, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2013 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
@@ -44,7 +44,7 @@ class ICache : public AbstractICache {
static void ppc64_flush_icache_bytes(address start, int bytes) {
// Align start address to an icache line boundary and transform
// nbytes to an icache line count.
const uint line_offset = mask_address_bits(start, line_size - 1);
const uint line_offset = (intptr_t)start & (line_size - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by comment: This used to be a uintptr_t cast, now its intptr_t- why signed? Was that a deliberate decision?

Side question, I always wondered about the widespread use of intptr_t in hotspot when casting pointers to integrals, e.g. in p2i(). Why a signed integer? E.g. if you then use it for bitwise ops (the major reason why one converts a pointer to an int) it seems more hassle to have to remember the rules for using bitwise operators on signed integers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas, thanks for noticing. I messed this one up.

Are you arguing for address_word to avoid this confusion? That's a lot of reeducation in the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Coleen, no, I was just wondering if the decision was deliberate. I may have overlooked a reason for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tstuefe p2i() is mainly used for printing, and the format uses hex so the signed-ness is immaterial. But in general, yes this seems an odd choice.

ppc64_flush_icache(start - line_offset, (bytes + line_offset + line_size - 1) >> log2_line_size, 0);
}
};