Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() #15325

Closed
wants to merge 21 commits into from
+51 −9
Closed

6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() #15325

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d52de28
Fix
prsadhuk Jun 9, 2023
f3a9171
Revert "Fix"
prsadhuk Jun 9, 2023
197f2f0
Merge remote-tracking branch 'upstream/master'
prsadhuk Jun 9, 2023
58d01e0
Merge remote-tracking branch 'upstream/master'
prsadhuk Jun 12, 2023
0b86026
Merge branch 'master' of github.com:prsadhuk/jdk
prsadhuk Jun 12, 2023
31bbdee
JDK-6510914: JScrollBar.getMinimumSize() breaks the contract of JComp…
prsadhuk Aug 17, 2023
d152b88
Fix maximumSize, test
prsadhuk Aug 24, 2023
be0a339
copyright year
prsadhuk Aug 24, 2023
9b96c33
Update spec
prsadhuk Oct 11, 2023
09b8b82
Spec update
prsadhuk Oct 19, 2023
6a9a1d5
Remove unneeded methods
prsadhuk Nov 3, 2023
2733ea6
Reinstate setEnabled
prsadhuk Nov 6, 2023
89aae1e
Override set*Methods and update spec
prsadhuk Nov 21, 2023
0e4df2a
Honour max/min size if set by user
prsadhuk Jan 3, 2024
1a7bc6e
javadoc updated
prsadhuk Jan 19, 2024
c651106
PR update as per review
prsadhuk Jan 23, 2024
2a42f5c
PR update as per review
prsadhuk Jan 23, 2024
10b670c
javadoc update in JScrollbar and JComponent
prsadhuk Jan 29, 2024
66a50bc
javadoc change
prsadhuk Jan 29, 2024
1d8fff4
Merge master
prsadhuk Jan 29, 2024
4937fcc
review update
prsadhuk Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/java.desktop/share/classes/javax/swing/JScrollBar.java
View file
Original file line number Diff line number Diff line change
@@ -782,8 +782,8 @@ public void setMaximumSize(Dimension maximumSize) {
/**
* The scrollbar is flexible along its scrolling axis and
* rigid along the other axis.
* As specified in {@code setMinimumSize} JScrollBar will derive the
* minimum size from the preferred size in one axis and a
* As specified in {@code setMinimumSize} JScrollBar will derive the
Copy link
Member

@aivanov-jdk aivanov-jdk Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look good to me. It is getMinimumSize that specifies what is returned; setMinimumSize just warns the programmer that getMinimumSize ignores the value passed to the set- method.

It's the other way around: getMinimumSize should specify and specifies what it returns — setMinimumSize is being updated to align with the implementation of the get-.

* minimum size from the preferred size in one axis and a
* fixed minimum size in the other.
*
* @return the minimum size as specified above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return the minimum size as specified above.
* @return the minimum size as specified above

@return tags usually don't have a period in the end. Let's follow it for consistency.

@@ -800,8 +800,8 @@ public Dimension getMinimumSize() {
/**
* The scrollbar is flexible along its scrolling axis and
* rigid along the other axis.
* As specified in {@code setMaximumSize} JScrollBar will derive the
* maximum size from the preferred size in one axis and a
* As specified in {@code setMaximumSize} JScrollBar will derive the
* maximum size from the preferred size in one axis and a
* fixed maximum size in the other.
*
* @return the maximum size as specified above.