Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6450193: After the first Serialization, JTableHeader does not uninstall its UI #15507

Closed
wants to merge 13 commits into from
+68 −14
Closed

6450193: After the first Serialization, JTableHeader does not uninstall its UI #15507

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d52de28
Fix
prsadhuk Jun 9, 2023
f3a9171
Revert "Fix"
prsadhuk Jun 9, 2023
197f2f0
Merge remote-tracking branch 'upstream/master'
prsadhuk Jun 9, 2023
58d01e0
Merge remote-tracking branch 'upstream/master'
prsadhuk Jun 12, 2023
0b86026
Merge branch 'master' of github.com:prsadhuk/jdk
prsadhuk Jun 12, 2023
3cfb3c3
Merge
prsadhuk Jun 14, 2023
77e2738
Merge remote-tracking branch 'upstream/master'
prsadhuk Jul 31, 2023
b8447dd
Merge remote-tracking branch 'upstream/master'
prsadhuk Aug 16, 2023
06faf84
Merge remote-tracking branch 'upstream/master'
prsadhuk Aug 28, 2023
a8df471
6450193: After the first Serialization, JTableHeader does not uninsta…
prsadhuk Aug 31, 2023
267a478
Review fix for test
prsadhuk Sep 21, 2023
7303c96
try-with-resource use
prsadhuk Sep 22, 2023
be24f0f
tag headful added
prsadhuk Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java
View file
Original file line number Diff line number Diff line change
@@ -55,11 +55,11 @@ public static void main(String[] args) throws Exception {
SwingUtilities.invokeAndWait(() -> setLookAndFeel(laf));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose to set LAF on EDT? You then continue with creating and serialising the component on the main thread.

Copy link
Contributor Author

@prsadhuk prsadhuk Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure if any event processing needs to be done for lookandfeel change particularly native l&f like GTK and Aqua.
Seems like it works with both EDT and non-EDT...tried with repeat count 50....so removed EDT usage...
however GTK is not supported on headless environment so made the test run on headful environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never thought about it… Yet if there's anything that depends on access to native platform, it probably needs to run on the toolkit thread.

I'm for keeping it simpler: if it works correctly on the main thread here, let's keep it this way.

JTableHeader jth = new JTableHeader();
for (int i = 0; i < 10; i++) {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
ObjectOutputStream oos = new ObjectOutputStream(baos);
//System.out.println(jth.getUI());
oos.writeObject(jth);
oos.writeObject(jth.getAccessibleContext());
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
ObjectOutputStream oos = new ObjectOutputStream(baos)) {
oos.writeObject(jth);
oos.writeObject(jth.getAccessibleContext());
}
}
}
}