Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315781: Reduce the max value of GCDrainStackTargetSize #15590

Closed
wants to merge 2 commits into from
+3 −9
Closed

8315781: Reduce the max value of GCDrainStackTargetSize #15590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6104cf2
g1-remove-default
albertnetymk Aug 31, 2023
ba16c5f
Update src/hotspot/share/gc/shared/gc_globals.hpp
albertnetymk Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/hotspot/share/gc/g1/g1Arguments.cpp
View file
Original file line number Diff line number Diff line change
@@ -230,11 +230,6 @@ void G1Arguments::initialize() {
FLAG_SET_DEFAULT(ParallelRefProcEnabled, true);
}

// By default do not let the target stack size to be more than 1/4 of the entries
if (FLAG_IS_DEFAULT(GCDrainStackTargetSize)) {
FLAG_SET_ERGO(GCDrainStackTargetSize, MIN2(GCDrainStackTargetSize, TASKQUEUE_SIZE / 4));
}

#ifdef COMPILER2
// Enable loop strip mining to offer better pause time guarantees
if (FLAG_IS_DEFAULT(UseCountedLoopSafepoints)) {
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/g1ConcurrentMark.cpp
View file
Original file line number Diff line number Diff line change
@@ -2319,7 +2319,7 @@ void G1CMTask::drain_local_queue(bool partially) {
// of things to do) or totally (at the very end).
uint target_size;
if (partially) {
target_size = MIN2(_task_queue->max_elems() / 3, GCDrainStackTargetSize);
target_size = GCDrainStackTargetSize;
} else {
target_size = 0;
}
3 changes: 1 addition & 2 deletions src/hotspot/share/gc/parallel/psPromotionManager.cpp
View file
Original file line number Diff line number Diff line change
@@ -183,8 +183,7 @@ PSPromotionManager::PSPromotionManager() {
if (ParallelGCThreads == 1) {
_target_stack_size = 0;
} else {
// don't let the target stack size to be more than 1/4 of the entries
_target_stack_size = MIN2(GCDrainStackTargetSize, (queue_size / 4));
_target_stack_size = GCDrainStackTargetSize;
}

_array_chunk_size = ParGCArrayScanChunk;
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/shared/gc_globals.hpp
View file
Original file line number Diff line number Diff line change
@@ -687,7 +687,7 @@
product(uint, GCDrainStackTargetSize, 64, \
"Number of entries we will try to leave on the stack " \
"during parallel gc") \
range(0, (UINT_MAX - 1) / 2) \
range(0, 8 * 1024) \
\
product(uint, GCCardSizeInBytes, 512, \
"Card table entry size (in bytes) for card based collectors") \