Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316003: Update FileChooserSymLinkTest.java to HTML instructions #15661

Closed
wants to merge 8 commits into from
+43 −30
Closed

8316003: Update FileChooserSymLinkTest.java to HTML instructions #15661

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d5343a
Enable HTML display if instructions start with <html>
aivanov-jdk Oct 12, 2022
db08cfc
Improve instruction formatting
aivanov-jdk Sep 11, 2023
80fec8a
Refactor configuration of a text component for instructions
aivanov-jdk Oct 12, 2022
7753b3f
Revert changes to FileChooserSymLinkTest.java
aivanov-jdk Sep 11, 2023
c388d73
Wrap createUI call
aivanov-jdk Sep 11, 2023
41eaf1b
Revert "Revert changes to FileChooserSymLinkTest.java"
aivanov-jdk Sep 11, 2023
a833901
Amend indentation of nested <li> elements
aivanov-jdk Sep 12, 2023
7377550
Merge master
aivanov-jdk Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 43 additions & 30 deletions test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -74,48 +74,61 @@ public void run() {
static void initialize() throws InterruptedException, InvocationTargetException {
//Initialize the components
final String INSTRUCTIONS = """
<html><body>
Instructions to Test:
1. Open an elevated Command Prompt.
2. Paste the following commands:
cd /d C:\\
<ol>
<li>Open an elevated <i>Command Prompt</i>.
<li>Paste the following commands:
<pre><code>cd /d C:\\
mkdir FileChooserTest
cd FileChooserTest
mkdir target
mklink /d link target
mklink /d link target</code></pre>
3. Navigate to C:\\FileChooserTest in the JFileChooser.
4. Use "Enable Multi-Selection" checkbox to enable/disable
MultiSelection Mode
5. Single-selection:
Click "link" directory, the absolute path of the symbolic
link should be displayed. If it's null, click FAIL.
Click "target" directory, its absolute path should be
displayed.
Enable multiple selection by clicking the checkbox.
Multi-selection:
Click "link", press Ctrl and then click "target".
Both should be selected and their absolute paths should be
displayed.
If "link" can't be selected or if its absolute path is null,
click FAIL.
If "link" can be selected in both single- and multi-selection modes,
click PASS.
6. When done with testing, paste the following commands to
remove the 'FileChooserTest' directory:
cd \\
rmdir /s /q C:\\FileChooserTest
<li>Navigate to <code>C:\\FileChooserTest</code> in
the <code>JFileChooser</code>.
<li>Perform testing in single- and multi-selection modes:
<ul style="margin-bottom: 0px">
<li><strong>Single-selection:</strong>
<ol>
<li>Ensure <b>Enable multi-selection</b> is cleared
(the default state).
<li>Click <code>link</code> directory,
the absolute path of the symbolic
link should be displayed.<br>
If it's <code>null</code>, click <b>Fail</b>.
<li>Click <code>target</code> directory,
its absolute path should be displayed.
</ol>
<li><strong>Multi-selection:</strong>
<ol>
<li>Select <b>Enable multi-selection</b>.
<li>Click <code>link</code>,
<li>Press <kbd>Ctrl</kbd> and
then click <code>target</code>.
<li>Both should be selected and
their absolute paths should be displayed.
<li>If <code>link</code> can't be selected or
if its absolute path is <code>null</code>,
click <b>Fail</b>.
</ol>
</ul>
<p>If <code>link</code> can be selected in both
single- and multi-selection modes, click <b>Pass</b>.</p>
<li>When done with testing, paste the following commands to
remove the <code>FileChooserTest</code> directory:
<pre><code>cd \\
rmdir /s /q C:\\FileChooserTest</code></pre>
or use File Explorer to clean it up.
</ol>
""";
frame = new JFrame("JFileChooser Symbolic Link test");
panel = new JPanel(new BorderLayout());
multiSelection = new JCheckBox("Enable Multi-Selection");
pathList = new JTextArea(10, 50);
jfc = new JFileChooser(new File("C:\\"));
passFailJFrame = new PassFailJFrame("Test Instructions", INSTRUCTIONS, 5L, 35, 40);
passFailJFrame = new PassFailJFrame("Test Instructions", INSTRUCTIONS, 5L, 35, 50);

PassFailJFrame.addTestWindow(frame);
PassFailJFrame.positionTestWindow(frame, PassFailJFrame.Position.HORIZONTAL);