Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316000: File.setExecutable silently fails if file does not exist #15673

Closed
wants to merge 8 commits into from
+36 −24
Closed

8316000: File.setExecutable silently fails if file does not exist #15673

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33a84f5
8316000: File.setExecutable silently fails if file does not exist
bplb Sep 11, 2023
08c5fd9
8316000: Revert implementation change; modify specification to match …
bplb Sep 19, 2023
9712535
8316000: Add the API notes to the corresponding single parameter methods
bplb Sep 19, 2023
8640dec
8316000: Move apiNotes to normative text; update @return descriptions
bplb Sep 20, 2023
8189784
8316000: Align the spec and return verbiage
bplb Sep 22, 2023
2ec7d22
8316000: Revert specification verbiage and modify @return description
bplb Sep 25, 2023
61cdf01
8316000: Modify spec and return verbiage
bplb Sep 26, 2023
5dabb21
8316000: Address comment https://github.com/openjdk/jdk/pull/15673#di…
bplb Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 34 additions & 38 deletions src/java.base/share/classes/java/io/File.java
View file
Original file line number Diff line number Diff line change
@@ -1621,8 +1621,11 @@ public boolean setWritable(boolean writable) {
* file attributes including file permissions. This may be used when finer
* manipulation of file permissions is required.
*
* <p> On platforms which do not support setting a file's read permission,
* this method does nothing and returns the value of the {@code readable}
* <p> If setting the read permission is supported, but the user does not
* have permission to change the access permissions of this abstract
* pathname, then the operation will fail. If the platform or underlying
* file system does not support setting a file's read permission, this
* method does nothing and returns the value of the {@code readable}
* parameter.
*
* @param readable
@@ -1636,13 +1639,9 @@ public boolean setWritable(boolean writable) {
* permission from that of others, then the permission will apply to
* everybody, regardless of this value.
*
* @return {@code true} if and only if the operation succeeded. The
* operation will fail if the user does not have permission to
* change the access permissions of this abstract pathname. The
* method fails if the user does not have permission to change the
* access permissions, or the platform supports file permissions
* but the underlying file system does not implement the
* read permission.
* @return {@code true} if the operation succeeds, {@code false} if it
* fails, or the value of the {@code readable} parameter if
* setting the read permission is not supported.
*
* @throws SecurityException
* If a security manager exists and its {@link
@@ -1676,21 +1675,20 @@ public boolean setReadable(boolean readable, boolean ownerOnly) {
* file.setReadable(arg, true)
* }
*
* <p> On platforms which do not support setting a file's read permission,
* this method does nothing and returns the value of the {@code readable}
* <p> If setting the read permission is supported, but the user does not
* have permission to change the access permissions of this abstract
* pathname, then the operation will fail. If the platform or underlying
* file system does not support setting a file's read permission, this
* method does nothing and returns the value of the {@code readable}
* parameter.
*
* @param readable
* If {@code true}, sets the access permission to allow read
* operations; if {@code false} to disallow read operations
*
* @return {@code true} if and only if the operation succeeded. The
* operation will fail if the user does not have permission to
* change the access permissions of this abstract pathname. The
* method fails if the user does not have permission to change the
* access permissions, or the platform supports file permissions
* but the underlying file system does not implement the
* read permission.
* @return {@code true} if the operation succeeds, {@code false} if it
* fails, or the value of the {@code readable} parameter if
* setting the read permission is not supported.
*
* @throws SecurityException
* If a security manager exists and its {@link
@@ -1713,9 +1711,12 @@ public boolean setReadable(boolean readable) {
* file attributes including file permissions. This may be used when finer
* manipulation of file permissions is required.
*
* <p> On platforms which do not support setting a file's execute
* permission, this method does nothing and returns the value of the
* {@code executable} parameter.
* <p> If setting the execute permission is supported, but the user does not
* have permission to change the access permissions of this abstract
* pathname, then the operation will fail. If the platform or underlying
* file system does not support setting a file's execute permission, this
* method does nothing and returns the value of the {@code executable}
* parameter.
*
* @param executable
* If {@code true}, sets the access permission to allow execute
@@ -1728,13 +1729,9 @@ public boolean setReadable(boolean readable) {
* execute permission from that of others, then the permission will
* apply to everybody, regardless of this value.
*
* @return {@code true} if and only if the operation succeeded. The
* operation will fail if the user does not have permission to
* change the access permissions of this abstract pathname. The
* method fails if the user does not have permission to change the
* access permissions, or the platform supports file permissions
* but the underlying file system does not implement the
* executable permission.
* @return {@code true} if the operation succeeds, {@code false} if it
* fails, or the value of the {@code executable} parameter if
* setting the execute permission is not supported.
*
* @throws SecurityException
* If a security manager exists and its {@link
@@ -1768,21 +1765,20 @@ public boolean setExecutable(boolean executable, boolean ownerOnly) {
* file.setExecutable(arg, true)
* }
*
* <p> On platforms which do not support setting a file's execute
* permission, this method does nothing and returns the value of the
* {@code executable} parameter.
* <p> If setting the execute permission is supported, but the user does not
* have permission to change the access permissions of this abstract
* pathname, then the operation will fail. If the platform or underlying
* file system does not support setting a file's execute permission, this
* method does nothing and returns the value of the {@code executable}
* parameter.
*
* @param executable
* If {@code true}, sets the access permission to allow execute
* operations; if {@code false} to disallow execute operations
*
* @return {@code true} if and only if the operation succeeded. The
* operation will fail if the user does not have permission to
* change the access permissions of this abstract pathname. The
* method fails if the user does not have permission to change the
* access permissions, or the platform supports file permissions
* but the underlying file system does not implement the
* executable permission.
* @return {@code true} if the operation succeeds, {@code false} if it
* fails, or the value of the {@code executable} parameter if
* setting the execute permission is not supported.
*
* @throws SecurityException
* If a security manager exists and its {@link