Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols #16414

Closed
wants to merge 13 commits into from
+206 −0
Closed

JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols #16414

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cfdcc26
Symbol Resolution fix for Panama changes.
suchismith1993 Oct 30, 2023
cb6ff00
Update symbols-aix-foreign
suchismith1993 Nov 8, 2023
5e4f3e5
Provide support for math library in inline way.
suchismith1993 Nov 21, 2023
4899c97
Remove symbols file after using inline way.
suchismith1993 Nov 21, 2023
0cd7811
Remove additional lines
suchismith1993 Nov 21, 2023
47e5fb5
Remove extra symbols.
suchismith1993 Nov 21, 2023
faad552
Revert lookup file in share directory.
suchismith1993 Nov 21, 2023
e0b22d4
Update Copyright
suchismith1993 Nov 21, 2023
d150525
Change comments
suchismith1993 Nov 21, 2023
48a69c5
Comments
suchismith1993 Nov 21, 2023
2383be7
Remove unnecessary includes
suchismith1993 Nov 21, 2023
efbb245
Fix Typos
suchismith1993 Nov 21, 2023
7a68313
Update src/java.base/aix/native/libsyslookup/syslookup.c copyright
suchismith1993 Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
209 changes: 209 additions & 0 deletions src/java.base/aix/native/libsyslookup/syslookup.c
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,209 @@
/*
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

// Note: the include below is not strictly required, as dependencies will be pulled using linker flags.
// Adding at least one #include removes unwanted warnings on some platforms.
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are string.h and stdlib.h needed? I can't see them in the comments below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string.h is needed for strlen. Let me check for stdlib.h by excluding it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, a comment above strlen would help.

#include <math.h>

// Simple dummy function so this library appears as a normal library to tooling.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this comment should be on line 207 instead..?

void* funcs[] = {
//stdio.h
&abs,
&strlen,
&strcat,
//math.h
&fabs,
&fabsf,
&fabsl,
&fmod,
&fmodf,
&fmodl,
&remainder,
&remainderf,
&remainderl,
&remquo,
&remquof,
&remquol,
&fma,
&fmaf,
&fmal,
&fmax,
&fmaxf,
&fmaxl,
&fmin,
&fminf,
&fminl,
&fdim,
&fdimf,
&fdiml,
&nan,
&nanf,
&nanl,
&exp,
&expf,
&expl,
&exp2,
&exp2f,
&exp2l,
&expm1,
&expm1f,
&expm1l,
&log,
&logf,
&logl,
&log10,
&log10f,
&log10l,
&log2,
&log2f,
&log2l,
&log1p,
&log1pf,
&log1pl,
&pow,
&powf,
&powl,
&sqrt,
&sqrtf,
&sqrtl,
&cbrt,
&cbrtf,
&cbrtl,
&hypot,
&hypotf,
&hypotl,
&sin,
&sinf,
&sinl,
&cos,
&cosf,
&cosl,
&tan,
&tanf,
&tanl,
&asin,
&asinf,
&asinl,
&acos,
&acosf,
&acosl,
&atan,
&atanf,
&atanl,
&atan2,
&atan2f,
&atan2l,
&sinh,
&sinhf,
&sinhl,
&cosh,
&coshf,
&coshl,
&tanh,
&tanhf,
&tanhl,
&asinh,
&asinhf,
&asinhl,
&acosh,
&acoshf,
&acoshl,
&atanh,
&atanhf,
&atanhl,
&erf,
&erff,
&erfl,
&erfc,
&erfcf,
&erfcl,
&tgamma,
&tgammaf,
&tgammal,
&lgamma,
&lgammaf,
&lgammal,
&ceil,
&ceilf,
&ceill,
&floor,
&floorf,
&floorl,
&trunc,
&truncf,
&truncl,
&round,
&roundf,
&roundl,
&lround,
&lroundf,
&lroundl,
&llround,
&llroundf,
&llroundl,
&nearbyint,
&nearbyintf,
&nearbyintl,
&rintf,
&rintl,
&lrint,
&lrintf,
&lrintl,
&llrint,
&llrintf,
&llrintl,
&frexpf,
&ldexpf,
&modff,
&scalbn,
&scalbnf,
&scalbnl,
&scalbln,
&scalblnf,
&scalblnl,
&ilogb,
&ilogbf,
&ilogbl,
&logb,
&logbf,
&logbl,
&nextafter,
&nextafterf,
&nextafterl,
&nexttoward,
&nexttowardf,
&nexttowardl,
&copysign,
&copysignf,
&copysignl,
&isnan
};

char* syslookup() {
return "syslookup";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not needed, either (see Windows version).

176 changes: 0 additions & 176 deletions src/java.base/share/native/libsyslookup/syslookup.c
View file
Original file line number Diff line number Diff line change
@@ -25,185 +25,9 @@

// Note: the include below is not strictly required, as dependencies will be pulled using linker flags.
// Adding at least one #include removes unwanted warnings on some platforms.
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <math.h>

// Simple dummy function so this library appears as a normal library to tooling.
void* funcs[] = {
//stdio.h
&abs,
&strlen,
&strcat,
//math.h
&fabs,
&fabsf,
&fabsl,
&fmod,
&fmodf,
&fmodl,
&remainder,
&remainderf,
&remainderl,
&remquo,
&remquof,
&remquol,
&fma,
&fmaf,
&fmal,
&fmax,
&fmaxf,
&fmaxl,
&fmin,
&fminf,
&fminl,
&fdim,
&fdimf,
&fdiml,
&nan,
&nanf,
&nanl,
&exp,
&expf,
&expl,
&exp2,
&exp2f,
&exp2l,
&expm1,
&expm1f,
&expm1l,
&log,
&logf,
&logl,
&log10,
&log10f,
&log10l,
&log2,
&log2f,
&log2l,
&log1p,
&log1pf,
&log1pl,
&pow,
&powf,
&powl,
&sqrt,
&sqrtf,
&sqrtl,
&cbrt,
&cbrtf,
&cbrtl,
&hypot,
&hypotf,
&hypotl,
&sin,
&sinf,
&sinl,
&cos,
&cosf,
&cosl,
&tan,
&tanf,
&tanl,
&asin,
&asinf,
&asinl,
&acos,
&acosf,
&acosl,
&atan,
&atanf,
&atanl,
&atan2,
&atan2f,
&atan2l,
&sinh,
&sinhf,
&sinhl,
&cosh,
&coshf,
&coshl,
&tanh,
&tanhf,
&tanhl,
&asinh,
&asinhf,
&asinhl,
&acosh,
&acoshf,
&acoshl,
&atanh,
&atanhf,
&atanhl,
&erf,
&erff,
&erfl,
&erfc,
&erfcf,
&erfcl,
&tgamma,
&tgammaf,
&tgammal,
&lgamma,
&lgammaf,
&lgammal,
&ceil,
&ceilf,
&ceill,
&floor,
&floorf,
&floorl,
&trunc,
&truncf,
&truncl,
&round,
&roundf,
&roundl,
&lround,
&lroundf,
&lroundl,
&llround,
&llroundf,
&llroundl,
&nearbyint,
&nearbyintf,
&nearbyintl,
&rintf,
&rintl,
&lrint,
&lrintf,
&lrintl,
&llrint,
&llrintf,
&llrintl,
&frexpf,
&ldexpf,
&modff,
&scalbn,
&scalbnf,
&scalbnl,
&scalbln,
&scalblnf,
&scalblnl,
&ilogb,
&ilogbf,
&ilogbl,
&logb,
&logbf,
&logbl,
&nextafter,
&nextafterf,
&nextafterl,
&nexttoward,
&nexttowardf,
&nexttowardl,
&copysign,
&copysignf,
&copysignl,
&isnan
};

char* syslookup() {
return "syslookup";
}