Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318915: Enhance checks in BigDecimal.toPlainString() #16457

Closed
wants to merge 2 commits into from
+57 −20
Closed

8318915: Enhance checks in BigDecimal.toPlainString() #16457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea4814
8318915: Enhance checks in BigDecimal.toPlainString()
rgiulietti Nov 1, 2023
8a3c0a9
Using repeat() instead of loop.
rgiulietti Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/java.base/share/classes/java/math/BigDecimal.java
View file
Original file line number Diff line number Diff line change
@@ -3503,22 +3503,19 @@ public String toPlainString() {
return "0";
}
int trailingZeros = checkScaleNonZero((-(long)scale));
StringBuilder buf;
String str = intCompact != INFLATED
? Long.toString(intCompact)
: intVal.toString();
int len = str.length() + trailingZeros;
if (len < 0) {
throw new OutOfMemoryError("too large to fit in a String");
}
buf = new StringBuilder(len);
StringBuilder buf = new StringBuilder(len);
buf.append(str);
for (int i = 0; i < trailingZeros; i++) {
buf.append('0');
}
buf.repeat('0', trailingZeros);
return buf.toString();
}
String str ;
String str;
if(intCompact!=INFLATED) {
str = Long.toString(Math.abs(intCompact));
} else {
@@ -3546,9 +3543,7 @@ private static String getValueString(int signum, String intString, int scale) {
}
buf = new StringBuilder(len);
buf.append(signum<0 ? "-0." : "0.");
for (int i = insertionPoint; i < 0; ++i) {
buf.append('0');
}
buf.repeat('0', -insertionPoint); // insertionPoint != MIN_VALUE
buf.append(intString);
}
return buf.toString();