Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8320005 : Allow loading of shared objects with .a extension on AIX #16604

Closed
wants to merge 46 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
12952b9
Add support for .a extension in jvm agent.
suchismith1993 Nov 10, 2023
999381f
Introduce new macro for AIX archives.
suchismith1993 Nov 14, 2023
1307f10
Move mapping function to aix specific file.
suchismith1993 Nov 15, 2023
f5bea14
Remove macro for file extension.
suchismith1993 Nov 20, 2023
27eee7b
Improve comments and coding style.
suchismith1993 Nov 22, 2023
b665f1e
Adapt hotspot coding style
suchismith1993 Nov 22, 2023
f54a6c3
change macro position
suchismith1993 Nov 22, 2023
e756f49
JDK-8320890
JoKern65 Dec 1, 2023
0f6716d
improve handling of nonexisting files
JoKern65 Dec 4, 2023
2d32c43
encapsulate everything in os::Aix::dlopen
JoKern65 Dec 5, 2023
b767682
followed the proposals
JoKern65 Dec 12, 2023
f342975
Following most of Thomas proposals
JoKern65 Dec 15, 2023
18d9d2b
trailing whitespace
JoKern65 Dec 15, 2023
978ed33
Followed Thomas proposals
JoKern65 Dec 18, 2023
f79c89d
cosmetic changes
JoKern65 Dec 18, 2023
eb09224
merge pr/16920
suchismith1993 Dec 19, 2023
9c6b80d
Add wrapper function to check extension before dlopen
suchismith1993 Dec 19, 2023
cac3f11
Remove AIX macros
suchismith1993 Dec 19, 2023
429597c
Change dll load function signature that does dlopen
suchismith1993 Dec 19, 2023
cd7e0e6
Change return type
suchismith1993 Dec 19, 2023
f3662a2
Remove trailing spaces.
suchismith1993 Dec 20, 2023
9df8c2c
Restore lines
suchismith1993 Dec 20, 2023
ffcbf78
Spaces fix
suchismith1993 Dec 20, 2023
6a5ce4a
Fix merge conflicts
suchismith1993 Jan 16, 2024
cbad4f9
update comment for reveiew
suchismith1993 Jan 27, 2024
257f5de
update comment
suchismith1993 Jan 27, 2024
713e514
Clarify comment
suchismith1993 Jan 31, 2024
af761ab
spelling
suchismith1993 Jan 31, 2024
f4c1788
Change logging
suchismith1993 Feb 5, 2024
14e0ed3
change control flow
suchismith1993 Feb 6, 2024
0503ed8
Free the buffer
suchismith1993 Feb 8, 2024
08cd36c
remove debug lines
suchismith1993 Feb 8, 2024
ccf8df7
debug lines
suchismith1993 Feb 8, 2024
f4b8535
spaces and comma
suchismith1993 Feb 8, 2024
ca75a33
update comment
suchismith1993 Feb 12, 2024
b5cf57d
Check to revert commit and do jcheck
suchismith1993 Feb 12, 2024
ecf8ad6
revert
suchismith1993 Feb 12, 2024
d887ad7
revert log_info
suchismith1993 Feb 12, 2024
c6332f6
Remove not matched trailing whitespaces
suchismith1993 Feb 12, 2024
f5693f4
Address review comments
suchismith1993 Feb 19, 2024
ae8e927
revert error code check
suchismith1993 Feb 19, 2024
c6b3deb
remove error_code
suchismith1993 Feb 19, 2024
664e41a
remove space
suchismith1993 Feb 20, 2024
1943445
Address review comments
suchismith1993 Feb 26, 2024
5791458
remove redundant logic
suchismith1993 Feb 27, 2024
5509044
indendt
suchismith1993 Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/hotspot/os/aix/os_aix.cpp
Original file line number Diff line number Diff line change
@@ -1175,6 +1175,7 @@
char* const pointer_to_dot = strrchr(file_path, '.');
if (pointer_to_dot == nullptr) {
log_info(os)("Attempting to load a shared object without extension %s", filename);
return result;
}
// First try to load the existing file.
result = dll_load_library(file_path, ebuf, ebuflen);
@@ -1195,7 +1196,7 @@
}

void os::get_summary_os_info(char* buf, size_t buflen) {
// There might be something more readable than uname results for AIX.

Check failure on line 1199 in src/hotspot/os/aix/os_aix.cpp

openjdk / jcheck-openjdk/jdk-16604

Whitespace error

Column 3: trailing whitespace Column 4: trailing whitespace Column 5: trailing whitespace Column 6: trailing whitespace
struct utsname name;
uname(&name);
snprintf(buf, buflen, "%s %s", name.release, name.version);