-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319896: Remove monitor deflation from final audit #16605
Closed
stefank
wants to merge
19
commits into
openjdk:master
from
stefank:8319896_remove_deflation_from_final_audit
+47
−50
Closed
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7526fce
Rework ObjectMonitorsHashtable for thread dumping
stefank 345e521
Add patricio's test
pchilano 9ca817a
Use a named constant
stefank 79f35c0
Update comments
stefank 591bd11
Move ConcurrentDeflation.java out of tier1
stefank 1185e9b
Update comment in ConcurrentDeflation.java
stefank 305b056
Punctuation
stefank 2180a0c
Rename monitors_iterate
stefank a90a4e3
Make monitors array public static
stefank 47d0eb5
Remove comment in do_monitors
stefank f33c0d9
Typos
stefank 605780d
Add AsyncMonitorDeflationForThreadDumpLimit flag
stefank 103d917
Tweak the flag comment a bit
stefank b7c23e0
Update comments
stefank f6283d6
Remove reinitialization in test
stefank 560c67d
Remove the limit for deflation requests
stefank 7a82c13
8319896: Remove monitor deflation from final audit
stefank a3df9b5
Merge remote-tracking branch 'upstream/master' into 8319896_remove_de…
stefank 7240356
Update comments
stefank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a conditional at line 1631 is_monitor_deflation_thread, and an else at 1657 that deflating idle monitors is at a safepoint. Should there not be this conditional, ie am I reading the description right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. The plan in my head has been to remove the safepointed monitor deflation first and then take a pass over the code and remove the various blocks that we don't execute anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coleenp I created a PR to clean this up:
#16706