Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321131: Console read line with zero out should zero out underlying buffer in JLine #16930

Closed
wants to merge 3 commits into from
+16 −3
Closed

8321131: Console read line with zero out should zero out underlying buffer in JLine #16930

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03e07d9
initial commit
naotoj Nov 30, 2023
a3773d4
moved instance fields at the top of the class
naotoj Dec 1, 2023
36ee3c8
Removed unnecessary modification in LineReader
naotoj Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
View file
Original file line number Diff line number Diff line change
@@ -67,6 +67,9 @@ public JdkConsole console(boolean isTTY, Charset charset) {
* public Console class.
*/
private static class JdkConsoleImpl implements JdkConsole {
private final Terminal terminal;
private volatile LineReader jline;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relocation looks good. Thanks!

@Override
public PrintWriter writer() {
return terminal.writer();
@@ -130,9 +133,6 @@ public Charset charset() {
return terminal.encoding();
}

private final Terminal terminal;
private volatile LineReader jline;

public JdkConsoleImpl(Terminal terminal) {
this.terminal = terminal;
}