8324641: [IR Framework] Add Setup method to provide custom arguments and set fields

test/hotspot/jtreg/compiler/lib/ir_framework/README.md

@@ -34,7 +34,7 @@ There are various ways how to set up and run a test within the `main()` method o
 The framework offers various annotations and flags to control how your test code should be invoked and being checked. This section gives an overview over all these features.
 
 ### 2.1 Different Tests
-There are two ways a test can be formulated, depending on how much control is needed over the test invocation.
+There are two ways a test can be written, depending on how much control is needed over the test invocation.
 
 #### Normal Test
 The normal and simplest form of testing provides a single `@Test` annotated method which the framework invokes directly as part of the testing. The test method either has no arguments, or they must be specified with an `@Arguments` annotation.

test/hotspot/jtreg/compiler/lib/ir_framework/Setup.java

@@ -28,11 +28,12 @@
 
 /**
  * This annotation is used to identify Setup methods. These can be used to compute arbitrary arguments for a test
- * method (see {@link Test}), as well as to set field values. A test method can use a setup method, by specifying it in a
- * {@link Arguments} annotation. A setup method can optionally take a {@link SetupInfo} as an argument. The
+ * method (see {@link Test}), as well as to set field values. A test method can use a setup method, by specifying
+ * it in a {@link Arguments} annotation. A setup method can optionally take a {@link SetupInfo} as an argument. The
  * arguments for the test methods are returned as a new object array.
  *
- * Examples on how to use test methods can be found in {@link ir_framework.examples.SetupExample} and also as part of the internal testing in the package {@link ir_framework.tests}.
+ * Examples on how to use test methods can be found in {@link ir_framework.examples.SetupExample} and also as part of the
+ * internal testing in the package {@link ir_framework.tests}.
  *
  * @see Arguments
  * @see Setup

test/hotspot/jtreg/compiler/lib/ir_framework/test/ArgumentsProvider.java

@@ -58,7 +58,7 @@ interface ArgumentsProvider {
  */
 class ArgumentsProviderBuilder {
    public static ArgumentsProvider build(Method method,
-                                          HashMap<String, Method> setupMethodMap) {
+                                         HashMap<String, Method> setupMethodMap) {
         Arguments argumentsAnnotation = method.getAnnotation(Arguments.class);
         if (argumentsAnnotation == null) {
             return new DefaultArgumentsProvider();
@@ -67,7 +67,7 @@ public static ArgumentsProvider build(Method method,
         Argument[] values = argumentsAnnotation.values();
         String setupMethodName = argumentsAnnotation.setup();
 
-        if (setupMethodName.length() > 0) {
+        if (!setupMethodName.isEmpty()) {
             TestFormat.check(values.length == 0,
                              "@Arguments: Can only specify \"setup\" or \"values\" but not both in " + method);
             TestFormat.check(setupMethodMap.containsKey(setupMethodName),