Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325163: Enable -Wpedantic on clang #17687

Closed
wants to merge 2 commits into from
+43 −12
Closed

8325163: Enable -Wpedantic on clang #17687

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de3c44
8325163: Enable -Wpedantic on clang
magicus Feb 2, 2024
ffa70af
FIx dtrace build
magicus Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion make/hotspot/lib/CompileJvm.gmk
View file
Original file line number Diff line number Diff line change
@@ -90,7 +90,7 @@ DISABLED_WARNINGS_gcc := array-bounds comment delete-non-virtual-dtor \

DISABLED_WARNINGS_clang := sometimes-uninitialized \
missing-braces delete-non-abstract-non-virtual-dtor unknown-pragmas \
gnu-zero-variadic-macro-arguments
gnu-zero-variadic-macro-arguments dollar-in-identifier-extension

ifneq ($(DEBUG_LEVEL), release)
# Assert macro gives warning

Unchanged files with check annotations Beta

View file
make/autoconf/build-aux/pkg.m4
# questions.
#
#

Check failure on line 28 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 1: trailing whitespace
# Copyright © 2004 Scott James Remnant <scott@netsplit.com>.
#
# This program is free software; you can redistribute it and/or modify
m4_pattern_allow([^PKG_CONFIG(_PATH)?$])
AC_ARG_VAR([PKG_CONFIG], [path to pkg-config utility])dnl
if test "x$ac_cv_env_PKG_CONFIG_set" != "xset"; then
AC_PATH_TOOL([PKG_CONFIG], [pkg-config])

Check failure on line 57 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
fi
if test -n "$PKG_CONFIG"; then
_pkg_min_version=m4_default([$1], [0.9.0])

Check failure on line 60 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
AC_MSG_CHECKING([pkg-config is at least version $_pkg_min_version])

Check failure on line 61 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
if $PKG_CONFIG --atleast-pkgconfig-version $_pkg_min_version; then

Check failure on line 62 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
AC_MSG_RESULT([yes])

Check failure on line 63 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 1: tab
else

Check failure on line 64 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
AC_MSG_RESULT([no])

Check failure on line 65 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 1: tab
PKG_CONFIG=""

Check failure on line 66 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 1: tab
fi

Check failure on line 67 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab

Check failure on line 68 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: trailing whitespace  
Column 1: trailing whitespace
fi[]dnl
])# PKG_PROG_PKG_CONFIG
elif test -n "$PKG_CONFIG"; then
PKG_CHECK_EXISTS([$3],
[pkg_cv_[]$1=`$PKG_CONFIG --[]$2 "$3" 2>/dev/null`],
[pkg_failed=yes])

Check failure on line 100 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 1: tab
else
pkg_failed=untried
fi[]dnl
if test $pkg_failed = yes; then
_PKG_SHORT_ERRORS_SUPPORTED
if test $_pkg_short_errors_supported = yes; then
$1[]_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors "$2" 2>&1`

Check failure on line 146 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
else

Check failure on line 147 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 12: trailing whitespace
$1[]_PKG_ERRORS=`$PKG_CONFIG --print-errors "$2" 2>&1`

Check failure on line 148 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
fi
# Put the nasty error message in config.log where it belongs

Check failure on line 150 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
echo "$$1[]_PKG_ERRORS" >&AS_MESSAGE_LOG_FD

Check failure on line 151 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
ifelse([$4], , [AC_MSG_ERROR(dnl

Check failure on line 153 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
[Package requirements ($2) were not met:
$$1_PKG_ERRORS
_PKG_TEXT
])],
[AC_MSG_RESULT([no])

Check failure on line 163 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 1: tab
$4])
elif test $pkg_failed = untried; then
ifelse([$4], , [AC_MSG_FAILURE(dnl

Check failure on line 166 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
[The pkg-config script could not be found or is too old. Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.
_PKG_TEXT
To get pkg-config, see <http://pkg-config.freedesktop.org/>.])],
[$4])

Check failure on line 174 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 1: tab
else
$1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS

Check failure on line 176 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
$1[]_LIBS=$pkg_cv_[]$1[]_LIBS

Check failure on line 177 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
AC_MSG_RESULT([yes])
ifelse([$3], , :, [$3])

Check failure on line 179 in make/autoconf/build-aux/pkg.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
fi[]dnl
])# PKG_CHECK_MODULES
View file
src/hotspot/cpu/aarch64/ad_encode.m4
dnl or visit www.oracle.com if you need additional information or have any
dnl questions.
dnl
dnl

Check failure on line 22 in src/hotspot/cpu/aarch64/ad_encode.m4

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 3: trailing whitespace
dnl Process this file with m4 ad_encode.m4 to generate the load/store
dnl patterns used in aarch64.ad.
dnl
View file
src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S
#

Check failure on line 1 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 1: trailing whitespace
# Copyright (c) 2004, 2013, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
#endif
# NOTE WELL! The _Copy functions are called directly
# from server-compiler-generated code via CallLeafNoFP,

Check failure on line 34 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
# which means that they *must* either not use floating

Check failure on line 35 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
# point or use it in the same manner as does the server

Check failure on line 36 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
# compiler.

Check failure on line 37 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab

Check failure on line 38 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: trailing whitespace
.globl SYMBOL(_Copy_arrayof_conjoint_bytes)
.globl SYMBOL(_Copy_arrayof_conjoint_jshorts)

Check failure on line 40 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
.globl SYMBOL(_Copy_conjoint_jshorts_atomic)
.globl SYMBOL(_Copy_arrayof_conjoint_jints)
.globl SYMBOL(_Copy_conjoint_jints_atomic)
.globl SYMBOL(_Copy_arrayof_conjoint_jlongs)
.globl SYMBOL(_Copy_conjoint_jlongs_atomic)
.text

Check failure on line 47 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
.globl SYMBOL(SpinPause)
.p2align 4,,15
# rdx - count, treated as ssize_t
#
.p2align 4,,15
ELF_TYPE(_Copy_arrayof_conjoint_bytes,@function)

Check failure on line 66 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
SYMBOL(_Copy_arrayof_conjoint_bytes):
movq %rdx,%r8 # byte count
shrq $3,%rdx # qword count
leaq -1(%rdi,%r8,1),%rax # from + bcount*1 - 1
jbe acb_CopyRight
cmpq %rax,%rsi
jbe acb_CopyLeft

Check failure on line 74 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 29: trailing whitespace
acb_CopyRight:
leaq -8(%rdi,%rdx,8),%rax # from + qcount*8 - 8
leaq -8(%rsi,%rdx,8),%rcx # to + qcount*8 - 8
# rdx - count, treated as ssize_t
#
.p2align 4,,15
ELF_TYPE(_Copy_arrayof_conjoint_jshorts,@function)

Check failure on line 168 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
ELF_TYPE(_Copy_conjoint_jshorts_atomic,@function)

Check failure on line 169 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
SYMBOL(_Copy_arrayof_conjoint_jshorts):
SYMBOL(_Copy_conjoint_jshorts_atomic):
movq %rdx,%r8 # word count
leaq -2(%rdi,%r8,2),%rax # from + wcount*2 - 2
jbe acs_CopyRight
cmpq %rax,%rsi
jbe acs_CopyLeft

Check failure on line 178 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 29: trailing whitespace
acs_CopyRight:
leaq -8(%rdi,%rdx,8),%rax # from + qcount*8 - 8
leaq -8(%rsi,%rdx,8),%rcx # to + qcount*8 - 8
# rdx - count, treated as ssize_t
#
.p2align 4,,15
ELF_TYPE(_Copy_arrayof_conjoint_jints,@function)

Check failure on line 258 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
ELF_TYPE(_Copy_conjoint_jints_atomic,@function)

Check failure on line 259 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
SYMBOL(_Copy_arrayof_conjoint_jints):
SYMBOL(_Copy_conjoint_jints_atomic):
movq %rdx,%r8 # dword count
leaq -4(%rdi,%r8,4),%rax # from + dcount*4 - 4
jbe aci_CopyRight
cmpq %rax,%rsi
jbe aci_CopyLeft

Check failure on line 268 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 29: trailing whitespace
aci_CopyRight:
leaq -8(%rdi,%rdx,8),%rax # from + qcount*8 - 8
leaq -8(%rsi,%rdx,8),%rcx # to + qcount*8 - 8
# rdx - count, treated as ssize_t
#
.p2align 4,,15
ELF_TYPE(_Copy_arrayof_conjoint_jlongs,@function)

Check failure on line 337 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
ELF_TYPE(_Copy_conjoint_jlongs_atomic,@function)

Check failure on line 338 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
SYMBOL(_Copy_arrayof_conjoint_jlongs):
SYMBOL(_Copy_conjoint_jlongs_atomic):
cmpq %rdi,%rsi
leaq -8(%rdi,%rdx,8),%rax # from + count*8 - 8
jbe acl_CopyRight
cmpq %rax,%rsi
jbe acl_CopyLeft

Check failure on line 345 in src/hotspot/os_cpu/bsd_x86/bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 29: trailing whitespace
acl_CopyRight:
leaq -8(%rsi,%rdx,8),%rcx # to + count*8 - 8
negq %rdx
View file
src/hotspot/os_cpu/bsd_x86/safefetch_bsd_x86_64.S
#
# %rdi : address
# %esi : defaultval
ELF_TYPE(SafeFetch32_impl,@function)

Check failure on line 47 in src/hotspot/os_cpu/bsd_x86/safefetch_bsd_x86_64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
SYMBOL(SafeFetch32_impl:)
SYMBOL(_SafeFetch32_fault:)
movl (%rdi), %eax
View file
src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S
// Clobber x1, flags.
// All other registers are preserved,
.global _ZN10JavaThread25aarch64_get_thread_helperEv

Check failure on line 28 in src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 8: tab
.type _ZN10JavaThread25aarch64_get_thread_helperEv, %function

Check failure on line 29 in src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab  
Column 6: tab
_ZN10JavaThread25aarch64_get_thread_helperEv:
hint #0x19 // paciasp

Check failure on line 32 in src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
stp x29, x30, [sp, -16]!

Check failure on line 33 in src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
adrp x0, :tlsdesc:_ZN6Thread12_thr_currentE

Check failure on line 34 in src/hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.S

openjdk / jcheck-openjdk/jdk-17687

Whitespace error 

Column 0: tab
ldr x1, [x0, #:tlsdesc_lo12:_ZN6Thread12_thr_currentE]
add x0, x0, :tlsdesc_lo12:_ZN6Thread12_thr_currentE
.tlsdesccall _ZN6Thread12_thr_currentE