Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325270 ProblemList two compiler/intrinsics/float16 tests that fail due to JDK-8324724 #17716

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 5, 2024

A trivial fix to ProblemList two compiler/intrinsics/float16 tests that fail due to JDK-8324724


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325270: ProblemList two compiler/intrinsics/float16 tests that fail due to JDK-8324724 (Sub-task - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17716/head:pull/17716
$ git checkout pull/17716

Update a local copy of the PR:
$ git checkout pull/17716
$ git pull https://git.openjdk.org/jdk.git pull/17716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17716

View PR using the GUI difftool:
$ git pr show -t 17716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17716.diff

Sorry, something went wrong.

…ue to JDK-8324724
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review February 5, 2024 22:42
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2024

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@dcubed-ojdk
The hotspot-compiler label was successfully added.

Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks trivial.

@dcubed-ojdk
Copy link
Member Author

@iwanowww - Thanks for the fast review!

/integrate auto

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325270: ProblemList two compiler/intrinsics/float16 tests that fail due to JDK-8324724

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated auto labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

Going to push as commit ab3b941.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 5, 2024
@openjdk openjdk bot closed this Feb 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@openjdk[bot] Pushed as commit ab3b941.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Feb 5, 2024

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8325270 branch May 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants