Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325880: Require minimum Open XL C/C++ version 17.1.1 #17857

Closed
wants to merge 3 commits into from
+3 −3
Closed

8325880: Require minimum Open XL C/C++ version 17.1.1 #17857

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cce3926
update XLC version
kimbarrett Feb 14, 2024
aa62a0a
Merge branch 'master' into update-xlc-version
kimbarrett Mar 5, 2024
bfbff28
Merge branch 'master' into update-xlc-version
kimbarrett Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/building.html
View file
Original file line number Diff line number Diff line change
@@ -562,7 +562,7 @@ <h2 id="native-compiler-toolchain-requirements">Native Compiler
</tr>
<tr class="odd">
<td>AIX</td>
<td>IBM XL C/C++</td>
<td>IBM Open XL C/C++</td>
</tr>
<tr class="even">
<td>Windows</td>
2 changes: 1 addition & 1 deletion doc/building.md
View file
Original file line number Diff line number Diff line change
@@ -382,7 +382,7 @@ one-to-one correlation between target operating system and toolchain.
| ------------------ | ------------------------- |
| Linux | gcc, clang |
| macOS | Apple Xcode (using clang) |
| AIX | IBM XL C/C++ |
| AIX | IBM Open XL C/C++ |
| Windows | Microsoft Visual Studio |

Please see the individual sections on the toolchains for version
2 changes: 1 addition & 1 deletion make/autoconf/toolchain.m4
View file
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ TOOLCHAIN_DESCRIPTION_xlc="IBM XL C/C++"
TOOLCHAIN_MINIMUM_VERSION_clang="3.5"
TOOLCHAIN_MINIMUM_VERSION_gcc="10.0"
TOOLCHAIN_MINIMUM_VERSION_microsoft="19.28.0.0" # VS2019 16.8, aka MSVC 14.28
TOOLCHAIN_MINIMUM_VERSION_xlc="16.1.0.0011"
TOOLCHAIN_MINIMUM_VERSION_xlc="17.1.1.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not build AIX with the xlc toolchain any more but the clang one. So this line only stops a build if someone is trying to build with xlc 16 against toolchain xlc.
I have to agree to @TheRealMDoerr, that the correct change would be to remove the xlc toolchain in jdk23 at all.


# Minimum supported linker versions, empty means unspecified
TOOLCHAIN_MINIMUM_LD_VERSION_gcc="2.18"