Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java applet test to main #18245

Closed
wants to merge 5 commits into from
+82 −86
Closed

JDK-8328000 : Convert /java/awt/im/8154816/bug8154816.java applet test to main #18245

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1954928
applet test to main
honkar-jdk Mar 12, 2024
7f6cd67
test file added
honkar-jdk Mar 12, 2024
aa6e534
removed extra newline
honkar-jdk Mar 12, 2024
b3aab57
added requires tag
honkar-jdk Mar 12, 2024
98a1380
instructions updated
honkar-jdk Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/jdk/java/awt/im/PinyinIMCapsTest.java
View file
Original file line number Diff line number Diff line change
@@ -41,8 +41,8 @@

public class PinyinIMCapsTest {
private static final String INSTRUCTIONS = """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can move INSTRUCTIONS to main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests follow this pattern and few others have it within main. I usually define it as static var so retaining it the same here.

This test is for OS X only. It verifies if the Caps Lock key works properly
with Pinyin input method, (i.e. if Caps Lock is pressed, input should be
The test verifies if the Caps Lock key works properly with Pinyin
input method, (i.e. if Caps Lock is pressed, input should be
switched to lowercase latin letters).
Test settings:
@@ -64,7 +64,7 @@ public static void main(String[] args) throws Exception {
.title("Test Pinyin Input Method")
.instructions(INSTRUCTIONS)
.rows((int) INSTRUCTIONS.lines().count() + 2)
.columns(50)
.columns(45)
.splitUIBottom(PinyinIMCapsTest::createUI)
.testTimeOut(10)
.build()