Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328402: Implement pausing functionality for the PassFailJFrame #18368

Closed
wants to merge 4 commits into from
+45 −12
Closed

8328402: Implement pausing functionality for the PassFailJFrame #18368

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85ba846
8328402: Implement pausing functionality for the PassFailJFrame
azvegint Mar 19, 2024
7f6f258
review comments
azvegint Mar 20, 2024
10f4580
TimeoutHandler -> TimeoutHandlerPanel
azvegint Mar 20, 2024
3005ee6
TimeoutHandlerPanel.PAUSE_BUTTON_LABEL -> PAUSE_BUTTON_LABEL
azvegint Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/jdk/java/awt/regtesthelpers/PassFailJFrame.java
View file
Original file line number Diff line number Diff line change
@@ -657,7 +657,7 @@ public TimeoutHandlerPanel(final long testTimeOut) {
+ TimeUnit.MINUTES.toMillis(testTimeOut);

label = new JLabel("", JLabel.CENTER);
button = new JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL);
button = new JButton(PAUSE_BUTTON_LABEL);

button.setFocusPainted(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's the default focus owner? Should we request focus to Pass instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's the default focus owner?

It is(e.g. with setFocusPainted(true)):
image

Should we request focus to Pass instead?

Probably not, to avoid accidentally passing the test, while hitting the pause is harmless.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure… Pause is not the main control. I guess the focus was in the instructions previously, we could preserve it. It may be not worth it though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear why we need a focus on the field with instructions.
The focus on the pause button makes sense:
Suppose someone is running many, many tests and decides to take a tea break, he just presses the space bar without moving the mouse.
(if he knows that the focus is on the pause button, setFocusPainted(false) :-) )

Anyway, if this bothers anyone we can come back to it later.

button.setFont(new Font(Font.DIALOG, Font.BOLD, 10));