-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328998: Encoding support for Intel APX extended general-purpose registers #18476
Closed
+888
−455
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
a2fc70f
Instruction encoding support for APX extended GPRs -- initial commit
steveatgh ec8cd90
Merge branch 'master' into apx-encoding-pr
steveatgh ad55f58
- inlcude previous WREX2 bug fix
steveatgh c55857b
add signature for 32-bit build
steveatgh 5f55f20
- add UseAPX x86 global
steveatgh 1ad335a
fix 32-bit build prefix functions
steveatgh 3d62dce
fix white space, add comments
steveatgh 95ce7df
bug fix in ::prefix_rex2
steveatgh eb246fd
bug fix in other ::prefix_rex2
steveatgh 7bd4b88
from review comments: simplification, fix comments and white space
steveatgh 21524ee
fix is_gpr arg on two functions with reversed src / dst operands
steveatgh 7f84551
fix 4 more src_is_gpr = true cases, add asserts to check for UseAPX
steveatgh 41398bb
add egpr support for popcntq(R,A), cvttsd2siq(R,A), popq(R)
steveatgh 01241d4
fixes: pp bits in crc32, REX2 branch in ldmxcsr
steveatgh 54d2226
fix stmxcrs REX2 branch, add asserts to SHA instructions
steveatgh c65fda0
remove is_map1 comment for addb, andb, movb, orb, testb, xchgb, xorb
steveatgh 46eb6b4
simplification and fix asserts in ldmxcsr, stmxcsr, and emit_prefix_a…
steveatgh 5300691
Update full name
steveatgh 7b12a4a
Merge branch 'master' into apx-encoding-pr
steveatgh 7b3e8ec
update for egpr use: bzhil(R,R,R), btq(R,R), btq(R,imm)
steveatgh d93e989
revert unneeded legacy flag change for kmovwl(K,K) and kmovql(K,K)
steveatgh 2a63a15
parameter and local renames, update comment
steveatgh 5262879
add ::needs_eevex for use with promoted map2 instructions (e.g. crc32)
steveatgh d4ecb31
enable EEVEX encoding of vex map2 instructions when UseAVX=2 if UseAP…
steveatgh aee89e7
fix entry condition for EEVEX encoding when UseAVX=2
steveatgh 826fa2b
conditionally allow EEVEX encoding when UseAVX=0
steveatgh 156bbfc
add asserts requiring UseAPX and UseAVX > 2 for egpr use with some in…
steveatgh 04a7db2
fix typo in two asserts
steveatgh 47885cb
simplify test in new asserts to just assert UseAPX
steveatgh 49b117e
added comment about UseAPX and UseAVX > 2 correspondence
steveatgh f054589
update APX warning text
steveatgh d2ac410
updated assert message
steveatgh 1d6ecba
disable UseAPX for now, move asserts to encoding check functions
steveatgh 5b6fdce
add comment to ::stmxcsr and ::ldmxcsr
steveatgh 47a0cd7
add comment about is_map1 prefix function parameter
steveatgh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, this could be:
emit_prefix_and_int8(get_prefixq(src, dst, true /* is_map1 */), (unsigned char) 0xB8);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.