-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328995: Launcher can't open jar files where the offset of the manifest is >4GB #18479
Closed
+230
−8
Closed
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1c01986
8328995: launcher can't open jar files where the offset of the manife…
cushon 8f908a0
Improvements
cushon 6b13ecc
Fix disk number size
cushon 7b599c9
Make cendsk an unsigned short
cushon d475de7
Maximum Zip64 extra field length is 32
cushon c2e16e1
Add some more comments
cushon 140e13b
Move test to test/jdk/tools/launcher
cushon da36c05
Merge remote-tracking branch 'origin/master' into JDK-8328995
cushon 875c81b
Merge branch 'master' into JDK-8328995
cushon 172609a
Add a missing `break`
cushon 1866109
Use /* instead of /** comments
cushon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing a
break;
here, after this innerif
block reads the zip64 extra fields and returnsJNI_TRUE
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, fixed. It is unnecessary to loop over any other extensions that are present after the zip64 one is found.